Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New behaviour for unregisterRequest #94

Open
jafyvilla opened this issue Apr 14, 2014 · 1 comment
Open

New behaviour for unregisterRequest #94

jafyvilla opened this issue Apr 14, 2014 · 1 comment

Comments

@jafyvilla
Copy link
Contributor

I think unregisterRequest should be deprecated and be replaced by a new function that behaves as the new registerRequest, including also the relinquish() call within.
Since the unregisterRequest method is meant to be used only when the request is no longer needed, it shouldn't wait anymore, so a relinquish() call should be implicit. Otherwise it would fall into a double wait() when the destructor gets called.

@eile
Copy link
Member

eile commented Apr 14, 2014

Agreed. Same applies to waitRequest(). I've already discussed this with @hernando

eile pushed a commit to eile/Lunchbox that referenced this issue Jul 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants