Install git pre-commit hook only if there's a directory to put it in #604

umlaeute · 2023-03-07T08:07:55Z

The assumption that we can put a file into .git/hooks/ if .git exists is wrong, e.g. if .git is a file (as is the case when using git submodule).

This PR fixes the issue by checking if .git/hooks/ exists instead:

the trailing slash checks for directories (or: directory-likes) rather than for mere existence (regardless of type)
since we want to put the target file into the hooks/ subdirectory we just check for that (just in case the .git directory is weird)

Closes: #603

Closes: Eyescale#603

Install git pre-commit hook only if there's a directory to put it in

e1186bf

Closes: Eyescale#603

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Install git pre-commit hook only if there's a directory to put it in #604

Install git pre-commit hook only if there's a directory to put it in #604

umlaeute commented Mar 7, 2023

Install git pre-commit hook only if there's a directory to put it in #604

Are you sure you want to change the base?

Install git pre-commit hook only if there's a directory to put it in #604

Conversation

umlaeute commented Mar 7, 2023