Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subproject git modules not cloned recursively #598

Open
NadirRoGue opened this issue Apr 15, 2020 · 0 comments
Open

Subproject git modules not cloned recursively #598

NadirRoGue opened this issue Apr 15, 2020 · 0 comments

Comments

@NadirRoGue
Copy link

NadirRoGue commented Apr 15, 2020

When running cmake, a subproject module is initialized and cloned, but this project modules are not cloned, however, causing the build to fail.

execute_process(COMMAND "${GIT_EXECUTABLE}" submodule update --recursive

The reason is that the call to git submodule init is not recursive, not registering the paths of the subproject module's modules, thus when the git submodule update --recursive call is executed, these non registered paths are not cloned.
Executing these 3 commands manually results in the same behaviour.

The test case is Brion https://github.com/BlueBrain/Brion
The scenario where this happens occurs when dealing with its sub module "libsonata". The structure is:

- Brion
    - libsonata
        - HighFive
        - fmt

If Brion is the subproject, when building, libsonata will be cloned, but HighFive and fmt (which are git submodules) will not be cloned.

adding --init to the line pointed above solves the problem, although it clones again CMake/common.

This can be fixed manually by running git submodule udpate --init in the problematic subprojects, however this cannot be applied to the CI jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant