Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve include/exclude rules #366

Open
SferaDev opened this issue Feb 11, 2020 · 0 comments
Open

Improve include/exclude rules #366

SferaDev opened this issue Feb 11, 2020 · 0 comments

Comments

@SferaDev
Copy link
Contributor

Originally excludeRules were properties that should be removed from the payload (ignored). While includeRules were REFERENCE properties that should be included into the payload.

With our current implementation we don't follow those definitions anymore, and we have overly simplified the concepts to a single MultiSelector.

The total options of the MultiSelector could be potentially calculated from the schema without any problem (this should avoid dataStore migrations too). So the excludeRules wouldn't be used anymore in the MultiSelector (as they never were the same concept as !includeRules).

However it would still be useful to allow deciding which optional properties (which can be default and or empty arrays) I want to remove from the payload. Maybe with another MultiSelector but not sure how.

Originally posted by @SferaDev in #336 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant