Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoPlayer 3rd Party Dependencies Are Not Typed #29

Open
grez96 opened this issue Jun 23, 2022 · 1 comment
Open

VideoPlayer 3rd Party Dependencies Are Not Typed #29

grez96 opened this issue Jun 23, 2022 · 1 comment
Assignees
@grez96

Comments

@grez96
Copy link
Contributor

grez96 commented Jun 23, 2022

react-background-video-player and fullscreen-handler. Have no types associated with them. Evaluate if it is possible to remove these dependencies all together and adopt a more native approach.
@grez96 grez96 self-assigned this Jun 23, 2022
@grez96 grez96 changed the title VideoPlayer Remove 3rd Party Dependencies Are Not Typed VideoPlayer 3rd Party Dependencies Are Not Typed Jun 23, 2022
@fzhang13
Copy link
Contributor

@namniak we should look into setting up typing for https://github.com/Jam3/fullscreen-handler similar to what we did for detect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grez96 grez96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fzhang13 @grez96