Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Possible Rules #23

Open
1 of 2 tasks
iranreyes opened this issue Jul 3, 2019 · 9 comments
Open
1 of 2 tasks

[Feature] Possible Rules #23

iranreyes opened this issue Jul 3, 2019 · 9 comments
Assignees

Comments

@iranreyes
Copy link
Member

iranreyes commented Jul 3, 2019

List of rules to add:

  • Lighthouse
  • Webhint
@iranreyes iranreyes self-assigned this Jul 3, 2019
@craighillwood
Copy link

@iranreyes I was thinking of a rule that checked that there is only one h1 per page.

@njam3
Copy link
Member

njam3 commented Jul 10, 2019

Lighthouse[in-progress]: https://github.com/Jam3/adviser-plugin-lighthouse

@iranreyes
Copy link
Member Author

iranreyes commented Aug 19, 2019

Idea

Create a plugin called adviser-plugin-privacy and create a rule that scans looking for hardcoded credentials.
Before creating this rule I would like to test what GitHub detects out of the box and use the tools to detect the rest.

Rule Specifications

Name: secrets

References

https://github.com/awslabs/git-secrets
https://github.com/Yelp/detect-secrets
https://www.npmjs.com/package/detect-secrets
https://geekflare.com/github-credentials-scanner/
https://securitytrails.com/blog/github-dorks
https://github.blog/2018-10-17-behind-the-scenes-of-github-token-scanning/

Notes

Create documentation for the rule within /docs/rules
Add metadata to the rule
Update the Plugin general README and add the new rule

Another possible rule

Avoid pushing .env files

@iranreyes
Copy link
Member Author

iranreyes commented Aug 19, 2019

SEO Combo:

Ideas:
h1
sitemap.xml
robots.txt
img alts
broken links
etc

@iranreyes
Copy link
Member Author

iranreyes commented Aug 19, 2019

Security combo:

Headers, CSP
Extra checkings
HTTPS implementation
External anchors should use noopnener, noreferrer
Run Owasp-zap, wp-scan, skipfish and others

@iranreyes
Copy link
Member Author

iranreyes commented Aug 19, 2019

Dependencies:

@iranreyes

This comment has been minimized.

@iranreyes

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants