-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit batching of updates with useOnyx
#571
Comments
Additionally, in fabric, react updates get batched automatically (if concurrent rendering is enabled) - so we might want to see if we can completely get rid of this manual batching mechanism. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In this PR:
We added support for batching updates, so that react only has to commit one big update, instead of updating every component separately. Back then there were only two subscription mechanisms:
Onyx.connect
withOnyx
Right now, we only batch updates for
withOnyx
. The reason for that is that in the NewDot code we have a lot of places that doOnyx.connect
outside of react and immediately expect data. So we only wanted to batchwithOnyx
updates, as these were only used with react:react-native-onyx/lib/OnyxUtils.ts
Lines 1004 to 1013 in c53826b
Now we have
useOnyx
, which internally usesOnyx.connect
, notwithOnyx
. So all components usinguseOnyx
might not be batched.I opened this issue because I want to look closer, if we need to enable a certain batching logic when using the
useOnyx
hook.The text was updated successfully, but these errors were encountered: