Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template specializations in BedrockCommand.cpp need to be inline #640

Open
wyoung opened this issue May 16, 2019 · 0 comments
Open

Template specializations in BedrockCommand.cpp need to be inline #640

wyoung opened this issue May 16, 2019 · 0 comments

Comments

@wyoung
Copy link

wyoung commented May 16, 2019

The specializations for SSynchronizedQueue<T>::push() and pop() need to be declared inline in BedrockCommand.cpp to avoid violation of the one definition rule. This problem was flagged by GCC 7.4.0 on Cygwin 3.0.7, but it's probably not Cygwin-specific.

See attached trivial patch for the exact change needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wyoung