Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expensify Card - Clicking on the bank account on a new workspace does nothing at first #51813

Open
1 of 8 tasks
lanitochka17 opened this issue Oct 31, 2024 · 19 comments
Open
1 of 8 tasks
Assignees
Labels
Engineering Overdue retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 31, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #49536

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create a workspace and enable expensify card
  3. Connect bank account
  4. Create another workspace
  5. Enable Expensify Cards
  6. Go to expensify cards and click on issue new card
  7. Click on the bank account added on the previous workspace
  8. Click again

Expected Result:

App should navigate to the next page on the first click

Actual Result:

App does nothing when clicking on the bank account but another page appears after waiting for a while

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6651198_1730385581085.bandicam_2024-10-31_17-30-16-556.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Oct 31, 2024
Copy link

melvin-bot bot commented Oct 31, 2024

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 31, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 2

@DylanDylann
Copy link
Contributor

This will be fixed after #51712 is merged

More detail: https://expensify.slack.com/archives/C05LX9D6E07/p1730300375653299?thread_ts=1728966082.429659&cid=C05LX9D6E07

@Julesssss
Copy link
Contributor

Thanks @DylanDylann. So I see that Aldo is needed for the backend change and is OOO for 2 weeks.

For the following reasons I'm not going to hold the deploy on this:

  • Backend deploys will block us for DAYS, even after it is fixed
  • This feature does work, it's just confusing as there is no feedback

@melvin-bot melvin-bot bot removed Overdue labels Nov 4, 2024
@Julesssss Julesssss added Daily KSv2 Overdue and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 4, 2024
@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 4, 2024
Copy link

melvin-bot bot commented Nov 11, 2024

@Julesssss 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@Julesssss
Copy link
Contributor

I bumped the PR, which seems to be stuck in review

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 11, 2024
Copy link

melvin-bot bot commented Nov 15, 2024

@Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Julesssss
Copy link
Contributor

Still awaiting the fix for this PR: #50423

@melvin-bot melvin-bot bot removed the Overdue label Nov 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 18, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

@Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Julesssss
Copy link
Contributor

Held as we await fix mentioned here

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 19, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

@Julesssss Huh... This is 4 days overdue. Who can take care of this?

@Julesssss
Copy link
Contributor

Same as above

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 25, 2024
@Julesssss
Copy link
Contributor

Here's the latest update from the held issue.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 28, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

@Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Julesssss
Copy link
Contributor

Held on another fix

@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
@Julesssss Julesssss added Weekly KSv2 and removed Daily KSv2 labels Dec 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 10, 2024
@Julesssss
Copy link
Contributor

Requesting retest as the linked bug has been resolved.

@melvin-bot melvin-bot bot removed the Overdue label Dec 11, 2024
@Julesssss Julesssss added Overdue retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause and removed Overdue labels Dec 11, 2024
@Julesssss
Copy link
Contributor

I accidentally added overdue, removing again

@melvin-bot melvin-bot bot added the Overdue label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Overdue retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants