Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD 49931] Expensify Card - Empty state screen not visible and issue card button and settings shown #51801

Closed
1 of 8 tasks
lanitochka17 opened this issue Oct 31, 2024 · 13 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 31, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #49536

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create a workspace and enable Expensify Card
  3. Click on Issue card and add a bank account
  4. Click on the bank account and wait for it to be verified
  5. Go to another workspace and go through the same steps from 1-4

Expected Result:

While the verification is ongoing an empty state screen should be shown on step 4 and on step 5 the issue card button and settings should not be visible

Actual Result:

While the verification is ongoing an empty state screen is not shown on step 4 and on step 5 the issue card button and settings are visible

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6651168_1730383244382.bandicam_2024-10-31_16-52-32-913.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @bfitzexpensify
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 31, 2024
Copy link

melvin-bot bot commented Oct 31, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment and removed Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 31, 2024
Copy link

melvin-bot bot commented Oct 31, 2024

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 31, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 2

@DylanDylann
Copy link
Contributor

DylanDylann commented Oct 31, 2024

@neil-marcellini
Copy link
Contributor

Thanks for pointing that out @DylanDylann! Sounds like this is a general issue across the whole app due to the way that Network requests are processed. Therefore I'll remove the blocker label and put this issue on HOLD for that one.

@neil-marcellini neil-marcellini added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 31, 2024
@neil-marcellini neil-marcellini changed the title Expensify Card - Empty state screen not visible and issue card button and settings shown [HOLD 49931] Expensify Card - Empty state screen not visible and issue card button and settings shown Oct 31, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@neil-marcellini
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Nov 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 28, 2024
@aldo-expensify
Copy link
Contributor

I'm making the backend PR ready for review: https://github.com/Expensify/Auth/pull/13168

@bfitzexpensify
Copy link
Contributor

Cool, we'll be able to circle around to this soon then

@melvin-bot melvin-bot bot removed the Overdue label Dec 1, 2024
@DylanDylann
Copy link
Contributor

@bfitzexpensify This bug has already been fixed

Screen.Recording.2024-12-09.at.14.32.06.mov

@melvin-bot melvin-bot bot added the Overdue label Dec 9, 2024
@bfitzexpensify
Copy link
Contributor

Nice, let's close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants