Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: "When to export" selector for auto-sync for NetSuite #51512

Open
yuwenmemon opened this issue Oct 25, 2024 · 5 comments
Open

New Feature: "When to export" selector for auto-sync for NetSuite #51512

yuwenmemon opened this issue Oct 25, 2024 · 5 comments
Assignees
Labels
External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Weekly KSv2

Comments

@yuwenmemon
Copy link
Contributor

yuwenmemon commented Oct 25, 2024

Hello! We need to build the following selector in the NetSuite configuration options:
364604714-6baa9d6b-fe87-43fd-bd28-d0844b9dc381

The "When to export" selector in the above mock-up is what we're adding.

The two options should have the following values (copied from the same feature in OldDot)

const accountingMethodOptions = [
    {
        value: 'ACCRUAL',
        text: 'Accrual',
        description: 'Out of pocket expenses will export when final approved',
    },
    {
        value: 'CASH',
        text: 'Cash',
        description: 'Out of pocket expenses will export when paid',
    },
];

Please use the constants defined in Expensify Common though: Expensify/expensify-common#817

The selection should be saved under the property accountingMethod in the NetSuite options.config object.

If there is no accountingMethod property set in the NetSuite config, the selector should default to CASH

Linked Expensify Issue: https://github.com/Expensify/Expensify/issues/422402

Issue OwnerCurrent Issue Owner: @aimane-chnaif
@yuwenmemon yuwenmemon added External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Help Wanted Apply this label when an issue is open to proposals by contributors labels Oct 25, 2024
@yuwenmemon yuwenmemon self-assigned this Oct 25, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 25, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

Triggered auto assignment to @mallenexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 25, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Oct 25, 2024

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

@yuwenmemon yuwenmemon removed the NewFeature Something to build that is a new item. label Oct 25, 2024
@yuwenmemon
Copy link
Contributor Author

yuwenmemon commented Oct 25, 2024

Removing NewFeature label since this does not fall under a project, and design has already reviewed.

@yuwenmemon yuwenmemon added the Improvement Item broken or needs improvement. label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants