-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] mWeb - Selector - User lands on the same WS when double tapping on different one on selector #51402
Comments
Triggered auto assignment to @stephanieelliott ( |
We think that this bug might be related to #wave-collect - Release 1 |
@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.Selector - User lands on the same WS when double tapping on different one on selector What is the root cause of that problem?On double click, only App/src/pages/WorkspaceSwitcherPage/index.tsx Lines 85 to 100 in 09f19c3
What changes do you think we should make in order to solve the problem?Implement debouncing to prevent double click
What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.mWeb - Selector - User lands on the same WS when double tapping on different one on selector What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
const isFocused = useIsFocused();
const selectPolicy = useCallback(
(option?: WorkspaceListItem) => {
if (!option || !isFocused) {
return;
}
const {policyID} = option;
setActiveWorkspaceID(policyID);
Navigation.goBack();
if (policyID !== activeWorkspaceID) {
Navigation.navigateWithSwitchPolicyID({policyID});
}
},
[activeWorkspaceID, setActiveWorkspaceID, isFocused], What alternative solutions did you explore? (Optional)Result |
Job added to Upwork: https://www.upwork.com/jobs/~021849976484014852041 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt ( |
@nyomanjyotisa Thanks for the proposal. Do you know why this happens on mWeb Chrome only? |
@Krishna2323 Thanks for the proposal. Same question ^ any idea why this does not happen on other platforms? |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.53-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5122323&group_by=cases:section_id&group_order=asc&group_id=296775
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
LHN should display the selected workspace chats when the user double taps over it in selector.
Actual Result:
User remains on the same workspace when trying to select "Expensify" option or next workspace on the selector list with double tapping.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6643981_1729740526844.Selector_WS.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @s77rtThe text was updated successfully, but these errors were encountered: