-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] mWeb - Dupe detect - Keyboard displayed below educational modal when open dupe expense #51398
Comments
Triggered auto assignment to @MitchExpensify ( |
We think that this bug might be related to #wave-control |
@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.mWeb - Dupe detect - Keyboard displayed below educational modal when open dupe expense What is the root cause of that problem?When opening expense page it auto focus on the composer input and automatically opens the keyboard, and we don't dismiss the keyboard if the hold menu displayed What changes do you think we should make in order to solve the problem?Dismiss keyboard if hold menu displayed/visible Add the following code here
What alternative solutions did you explore? (Optional) |
Edited by proposal-police: This proposal was edited at 2024-10-24 12:43:25 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.mWeb - Dupe detect - Keyboard displayed below educational modal when open dupe expense What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)Result |
ProposalPlease re-state the problem that we are trying to solve in this issue.mWeb - Dupe detect - Keyboard displayed below educational modal when open dupe expense What is the root cause of that problem?The composer auto focuses on opening the transaction thread and then popover will be open as soon as App/src/components/MoneyRequestHeader.tsx Line 127 in f46bce0
so the popover will overlap with the keyboard What changes do you think we should make in order to solve the problem?We should blur the report action compose whenever we display the hold menu (isVisible changes to true)
FYI: Keyboard.dismiss doesn't suffice as the cursor will be visible under the popover and most importantly it doesn't work for web What alternative solutions did you explore? (Optional)We can also use Focus Trap in ProcessMoneyRequestHoldMenu (or generally in Popover component) by passing |
Job added to Upwork: https://www.upwork.com/jobs/~021849586790771531414 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav ( |
@MitchExpensify this is a dupe of an older issue #51060 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.53-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team
Action Performed:
and log in with a new account
Expected Result:
The keyboard is hidden when the educational modal opens
Actual Result:
The keyboard is displayed below the educational modal
It does not happen when manually putting an expense on hold
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6644031_1729746958861.video_2024-10-24_01-15-27.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @mananjadhavThe text was updated successfully, but these errors were encountered: