Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop - Unexpected error when try to select the purpose "Chat and split" #51395

Open
1 of 8 tasks
IuliiaHerets opened this issue Oct 24, 2024 · 3 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.53-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5123689
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch App
  2. Create a new user (gmail)
  3. Select the purpose "Chat and split expenses with friends"
  4. Click on "Continue"
  5. Verify that the "What’s your name?" modal appears
  6. Enter any names
  7. Click on "Continue"

Expected Result:

User should land to Concierge chat without issues.

Actual Result:

"What do you want to do today?" modal appeared again and errors appeared in Concierge chat.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6643819_1729723484035.chat_and_split.mp4

View all open jobs on GitHub
Bug6643819_1729723484035!Screenshot_2024-10-23_at_18 34 15

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 24, 2024
Copy link

melvin-bot bot commented Oct 24, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@NJ-2020
Copy link
Contributor

NJ-2020 commented Oct 24, 2024

Edited by proposal-police: This proposal was edited at 2024-10-26 04:12:11 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Desktop - Unexpected error when try to select the purpose "Chat and split"

What is the root cause of that problem?

BE returns error saying
Screenshot 2024-10-24 at 03 25 45
It's because we pass undefined value if the completedTaskReportAction?.reportActionID is null

completedTaskReportActionID: completedTaskReportAction?.reportActionID ?? undefined,

What changes do you think we should make in order to solve the problem?

We should pass '-1'or '0' as we're changing now from'-1'to'0'`

What alternative solutions did you explore? (Optional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants