-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expense - Hourglass message and report header title is not displayed in Spanish #51167
Comments
Triggered auto assignment to @OfstadC ( |
@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.Hourglass message and report header title is not displayed in Spanish What is the root cause of that problem?It is handled from here Lines 257 to 283 in da68c0b
The whole NextStepUtils file is hard coded in English. What changes do you think we should make in order to solve the problem?Make use of translate function for the whole NextStepUtils file to tackle current and all the future similar issues. What alternative solutions did you explore? (Optional)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Expense - Hourglass message and report header title is not displayed in Spanish What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?We should add the necessary copys for these cases and display them
What alternative solutions did you explore? (Optional) |
Will hopefully get to this today |
Posting in Slack |
This isn't supported currently and we don't have immediate plans to change this - closing |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: V9. 0.51-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team
Action Performed:
Pre-condition:
Steps:
Expected Result:
Hourglass message and report header title must be displayed in Spanish.
Actual Result:
Hourglass message and report header title is not displayed in Spanish.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6640789_1729501044975.Screenrecorder-2024-10-21-14-16-09-637_compress_1.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: