-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] IOS - Expense/IOU - Keyboard overlaps camera when replacing receipt #51063
Comments
Triggered auto assignment to @JmillsExpensify ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Keyboard overlaps with camera view when replacing receipt. What is the root cause of that problem?When we click on App/src/components/AttachmentModal.tsx Lines 419 to 428 in 8ca4576
This closeModal executes onModalClose if it is a functionApp/src/components/AttachmentModal.tsx Lines 381 to 386 in 8ca4576
We dismiss the attachment modal in TransactionReceiptPage here in onModalClose App/src/pages/TransactionReceiptPage.tsx Lines 53 to 58 in 8ca4576
When we dispatch two such navigation actions (dismissModal and navigate to scan page) one after another immediately, we cannot be sure of the order in which they execute and the actions seem to be interfere with each other.
Using What changes do you think we should make in order to solve the problem?We should wait for the navigation actions in App/src/components/AttachmentModal.tsx Line 420 in 8ca4576
to Navigation.setNavigationActionToMicrotaskQueue(() => Navigation.navigate( so that the next navigation action is added to the micro task queue and gets executed only after the previous navigation action is complete. What alternative solutions did you explore? (Optional) |
@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this? |
Opening up to the community. |
Job added to Upwork: https://www.upwork.com/jobs/~021849498756209836053 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox ( |
@c3024 Thank you for your proposal. However, your RCA isn’t clear about which event or referenced code is triggering the input focus that opens the keyboard. Could you please provide more information on that point? |
When we go to a report without any messages, composer autofocuses here App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx Line 306 in 66112d1
So, when we close the attachment modal we return to the money request report and the money request view is not considered a message so the composer autofocuses and the keyboard shows up. I think when the navigation actions are dispatched simultaneously and not successively, the focus seems to trigger later than the second navigation action (here opening the scan page) or the next navigation to scan page happens before the blurring of the composer and the keyboard remains visible. |
ProposalPlease re-state the problem that we are trying to solve in this issue.IOS - Expense/IOU - Keyboard overlaps camera when replacing receipt What is the root cause of that problem?On pressing What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional) |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.50
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The keyboard is hidden
Actual Result:
The keyboard is still displayed and overlaps the camera
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6638131_1729195839730.IMG_0494.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @suneoxThe text was updated successfully, but these errors were encountered: