Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] mWeb - Expense - Second WS member can´t access report and receipt of distance split expenses #51022

Open
1 of 8 tasks
lanitochka17 opened this issue Oct 17, 2024 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 17, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5092497&group_by=cases:section_id&group_order=asc&group_id=229067
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open the staging.new.expensify.com website
  2. Open a workspace chat with at least two members
  3. Tap on the "+" button
  4. Tap on "Split Expense" and go to distance option
  5. Add start and stop waypoints
  6. Submit the expense
  7. Verify the user can open the expense report and receipt
  8. Log out from the account
  9. Log in with the account of the second workspace member
  10. Open the workspace chat
  11. Verify the second member can access the expense report and receipt

Expected Result:

Second expense participant, should be able to open the expense report and the receipt from the workspace chat

Actual Result:

When the second participant, opens the distance expense receipt, a "403 Forbidden" message is displayed, and when the report is opened, a "Hmmm, it´s not here" screen is displayed. Second Participant is not able to access the distance split expense information

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6637316_1729147085485.Distance_Split.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021848259328541792445
  • Upwork Job ID: 1848259328541792445
  • Last Price Increase: 2024-10-21
Issue OwnerCurrent Issue Owner: @deetergp
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@kadiealexander kadiealexander added the External Added to denote the issue can be worked on by a contributor label Oct 21, 2024
@melvin-bot melvin-bot bot changed the title mWeb - Expense - Second WS member can´t access report and receipt of distance split expenses [$250] mWeb - Expense - Second WS member can´t access report and receipt of distance split expenses Oct 21, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021848259328541792445

@melvin-bot melvin-bot bot added Overdue Help Wanted Apply this label when an issue is open to proposals by contributors labels Oct 21, 2024
Copy link

melvin-bot bot commented Oct 21, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

@melvin-bot melvin-bot bot removed the Overdue label Oct 21, 2024
@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@VickyStash
Copy link
Contributor

I was able to reproduce the issue, but it looks like an API problem. The app just displays what API returns.

So for the User A - the owner of the workspace and the creator of the split expense - the expense report is returned for OpenApp / OpenReport API command.

For User B - the member of the workspace - the expense report is not returned by the API inside OpenReport data. OpenReport call returns Report not found error.

NOTE : the issue is fixed if I turn User B into Admin of the workspace.

API calls User A (the one who created the split expense) User B (second member of the workspace)
OpenApp 2 01
OpenReport 3 02
Receipt display image 04

@VickyStash
Copy link
Contributor

@ikevin127 What do you think about this?

@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2024
@ikevin127
Copy link
Contributor

ikevin127 commented Oct 23, 2024

@VickyStash Thanks for the detailed explanation! Your analysis indicates that this is BE related indeed, so I'm going to auto-assign a CME to look into it and confirm whether this should be Internal.

cc @deetergp

🎀👀🎀 C+ reviewed

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2024
Copy link

melvin-bot bot commented Oct 23, 2024

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@kadiealexander
Copy link
Contributor

Reassigning to someone else to babysit this while I'm OOO for the next two weeks.

@kadiealexander kadiealexander removed the Bug Something is broken. Auto assigns a BugZero manager. label Oct 25, 2024
@kadiealexander kadiealexander removed their assignment Oct 25, 2024
@kadiealexander kadiealexander added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 25, 2024
@kadiealexander kadiealexander self-assigned this Oct 25, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@deetergp
Copy link
Contributor

I am not able to recreate this. I've tried splitting distance expenses both in and out of workspace chats and in each case, I am able to see both the expenses and the receipts as either user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
Status: Polish
Development

No branches or pull requests

6 participants