Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$125] Android- Emojis -Some emojis are blacked out and seen with a square with skin tone in composer #50929

Closed
2 of 8 tasks
IuliiaHerets opened this issue Oct 16, 2024 · 31 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Oct 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5088056&group_by=cases:section_id&group_order=asc&group_id=229070
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the Expensify app.
  2. Open any chat.
  3. Open the emoji picker.
  4. Start scrolling down and verify each emoji is rendered correctly.
  5. Select any and emoji that is displayed blacked out. (For example: 🫴)
  6. Verify the emoji is correctly displayed when added to compose box.

Expected Result:

All the emojis in compose box should be displayed without any reduced opacity and should be correctly added to compose box when selected.

Actual Result:

Some emojis are displayed blacked out in compose box and are displayed with a code and a square with the skin tone in compose box, when selected.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6636511_1729084254740.Blacked_Out.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021846719033693258327
  • Upwork Job ID: 1846719033693258327
  • Last Price Increase: 2024-10-17
  • Automatic offers:
    • akinwale | Reviewer | 104551467
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 16, 2024
Copy link

melvin-bot bot commented Oct 16, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@IuliiaHerets
Copy link
Author

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@greg-schroeder greg-schroeder added the External Added to denote the issue can be worked on by a contributor label Oct 17, 2024
@melvin-bot melvin-bot bot changed the title Android- Emojis -Some emojis are blacked out and seen with a square with skin tone in composer [$250] Android- Emojis -Some emojis are blacked out and seen with a square with skin tone in composer Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021846719033693258327

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

@greg-schroeder greg-schroeder changed the title [$250] Android- Emojis -Some emojis are blacked out and seen with a square with skin tone in composer [$125] Android- Emojis -Some emojis are blacked out and seen with a square with skin tone in composer Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Upwork job price has been updated to $125

@teneeto
Copy link
Contributor

teneeto commented Oct 17, 2024

Hey! I'm Eto Olei from Callstack. I will like to take a look at this issue. Please assign it to me. Thanks!

@Anaslancer
Copy link
Contributor

Anaslancer commented Oct 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Some emojis are blacked out and seen with a square with skin tone in composer

What is the root cause of that problem?

We are missing some emoji unicodes in the source code.

What changes do you think we should make in order to solve the problem?

We should put the correct unicode in here.

What alternative solutions did you explore? (Optional)

If the browser(like Chrome, Safari) can not render the emoji unicode, we can add the svg file instead.

Contributor details

Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01aff093c9a804b145

Copy link

melvin-bot bot commented Oct 17, 2024

📣 @Anaslancer! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Copy link
Contributor

anas-1995 Your proposal will be dismissed because you did not follow the proposal template.

@Anaslancer
Copy link
Contributor

Updated, it works?

Copy link

melvin-bot bot commented Oct 22, 2024

@akinwale, @greg-schroeder Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Oct 22, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 23, 2024
Copy link

melvin-bot bot commented Oct 23, 2024

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2024
@greg-schroeder
Copy link
Contributor

Assigning to @teneeto from CS

@Anaslancer
Copy link
Contributor

@akinwale , @greg-schroeder Did you have a chance to review my proposal?

@Anaslancer
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Some emojis are blacked out and seen with a square with skin tone in composer

What is the root cause of that problem?

We are missing some emoji unicodes in the source code.

What changes do you think we should make in order to solve the problem?

We should put the correct unicode in here.

What alternative solutions did you explore? (Optional)

If the browser(like Chrome, Safari) can not render the emoji unicode, we can add the svg file instead.

Contributor details

Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01aff093c9a804b145

@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2024
Copy link

melvin-bot bot commented Oct 25, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@Anaslancer
Copy link
Contributor

Submit again here, because bot says my proposal will be dismissed.

@teneeto
Copy link
Contributor

teneeto commented Oct 28, 2024

Working on this now. will provide more details as I continue.

Copy link

melvin-bot bot commented Oct 28, 2024

@akinwale, @teneeto, @greg-schroeder Huh... This is 4 days overdue. Who can take care of this?

@greg-schroeder
Copy link
Contributor

Thanks @teneeto

Copy link

melvin-bot bot commented Oct 30, 2024

@akinwale @teneeto @greg-schroeder this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Oct 30, 2024

@akinwale, @teneeto, @greg-schroeder 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@teneeto
Copy link
Contributor

teneeto commented Oct 31, 2024

Hi @akinwale, I paused a bit to finalise on another issue. I'll continue with this later today or first thing by tomorrow morning.

@greg-schroeder
Copy link
Contributor

Thanks @teneeto

Copy link

melvin-bot bot commented Nov 1, 2024

@akinwale, @teneeto, @greg-schroeder 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@melvin-bot melvin-bot bot removed the Overdue label Nov 1, 2024
@teneeto
Copy link
Contributor

teneeto commented Nov 5, 2024

Hey Melvin, I still have an eye on this.

@teneeto
Copy link
Contributor

teneeto commented Nov 6, 2024

Sorry for the delays, but I just got freed up with some capacity to investigate this now. I'm currently investigating this and will share any outcome.

@teneeto
Copy link
Contributor

teneeto commented Nov 7, 2024

Screen.Recording.2024-11-07.at.09.30.47.mov

Can we re-test to confirm this issue still happens? Although I haven't tested on real device (can't get my hands on my android device at the moment), but I did try on simulator and it seems to work perfectly.

@greg-schroeder greg-schroeder added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Nov 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@greg-schroeder
Copy link
Contributor

Pinging QA for a retest

@melvin-bot melvin-bot bot removed the Overdue label Nov 11, 2024
@muttmuure muttmuure moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Nov 12, 2024
@greg-schroeder
Copy link
Contributor

I also couldn't reproduce, so I'm going to close this as fixed elsewhere. Please reopen if you're able to reproduce.

@github-project-automation github-project-automation bot moved this from Bugs and Follow Up Issues to Done in [#whatsnext] #expense Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause
Projects
Archived in project
Development

No branches or pull requests

5 participants