-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Approver - Existing approver settings reverts to default after upgrading workspace plan #50924
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
We think that this bug might be related to #wave-control |
@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Edited by proposal-police: This proposal was edited at 2024-10-16 17:02:28 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Edit to the approval workflow is reset after upgrading the workspace from the additional approver flow. What is the root cause of that problem?When we go back from the upgrade page, we will call App/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx Lines 98 to 101 in 19b489c
Then, we call App/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx Lines 39 to 46 in 19b489c
Because the page is closed and then reopened, the flow is restarted. What changes do you think we should make in order to solve the problem?Don't always call
Then, we can remove the App/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx Lines 99 to 111 in 19b489c
|
ProposalPlease re-state the problem that we are trying to solve in this issue.The existing approver settings in Step 6 reverts to default after upgrading workspace plan. What is the root cause of that problem?After calling the App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsEditPage.tsx Lines 105 to 113 in fd2e0cb
What changes do you think we should make in order to solve the problem?We will not reset the approval workflow when the policy type changes.
What alternative solutions did you explore? (Optional) |
Reproduced. |
Job added to Upwork: https://www.upwork.com/jobs/~021847030936559806669 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 ( |
Pending @ishpaul777 review of proposals |
Thanks for ping, i'll review in couple hours |
Great. TY! |
I swear i am on it today 🙇 |
Proposal from @bernhardoj works well and LGTM! 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @MarioExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Very well, proposal looks good @bernhardoj!! Thank you @ishpaul777, let's move forward. |
📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
PR is ready cc: @ishpaul777 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.49-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
The existing approver settings in Step 6 will be preserved.
Actual Result:
The existing approver settings in Step 6 reverts to default after upgrading workspace plan.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6636230_1729067871531.20241016_163338.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ishpaul777The text was updated successfully, but these errors were encountered: