-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] IOU - Payment option not updated in IOU details when it changed on IOU preview #50916
Comments
Triggered auto assignment to @garrettmknight ( |
@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Edited by proposal-police: This proposal was edited at 2024-10-16 16:24:58 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.IOU - Payment option not updated in IOU details when it changed on IOU preview What is the root cause of that problem?We are currently only saving the payment preference if the report is linked to some policy so it won't save the preference for a DM as in this case. App/src/components/SettlementButton/index.tsx Lines 247 to 250 in 4a25c36
What changes do you think we should make in order to solve the problem?We can save the payment preference with App/src/components/SettlementButton/index.tsx Lines 247 to 250 in 4a25c36
Line 6800 in 4a25c36
What alternative solutions did you explore? (Optional)We can also save one payment preference for all non-workspace chats and in that case we can save the preference with the same key for all chats and access it with the key accordingly. |
Edited by proposal-police: This proposal was edited at 2024-10-17 12:40:22 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.The payment option does get changed on the IOU details. What is the root cause of that problem?
App/src/components/SettlementButton/index.tsx Lines 246 to 251 in 4a25c36
What changes do you think we should make in order to solve the problem?
App/src/components/SettlementButton/index.tsx Line 250 in 4a25c36
What alternative solutions did you explore? (Optional)
|
@garrettmknight Huh... This is 4 days overdue. Who can take care of this? |
Job added to Upwork: https://www.upwork.com/jobs/~021848758425092470966 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws ( |
This is an inconsistency we can fix, but it's not attached to any project so if it requires any internal/backend changes, I'll close, but if we can complete entirely externally I'm cool with fixing. |
It's totally about saving preference in FE @garrettmknight don't worry 👍 |
@truph01 Screen.Recording.2024-10-23.at.15.57.08.mov |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.49.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5087309
Issue reported by: Applause Internal Team
Action Performed:
Precondition: user B sent an IOU to user A
Expected Result:
The payment option is the same on both IOU preview and IOU details
Actual Result:
The payment option does get changed on the IOU details.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6635794_1729028836280.Recording__866.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @OllywsThe text was updated successfully, but these errors were encountered: