-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QBD] Restrict QBD to Control plans #50890
[QBD] Restrict QBD to Control plans #50890
Conversation
@@ -4006,6 +4006,11 @@ const translations = { | |||
description: `Disfruta de una sincronización automatizada y reduce las entradas manuales con la integración Expensify + Sage Intacct. Obtén información financiera en profundidad y en tiempo real con dimensiones definidas por el usuario, así como codificación de gastos por departamento, clase, ubicación, cliente y proyecto (trabajo).`, | |||
onlyAvailableOnPlan: 'Nuestra integración Sage Intacct sólo está disponible en el plan Control, a partir de ', | |||
}, | |||
[CONST.POLICY.CONNECTIONS.NAME.QBD]: { | |||
title: 'QuickBooks Desktop', | |||
description: `Disfruta de la sincronización automática y reduce las entradas manuales con la integración de Expensify + QuickBooks Desktop. Obtén la máxima eficiencia con una conexión bidireccional en tiempo real y la codificación de gastos por clase, artículo, cliente y proyecto.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used JamesGPT
And I'm waiting for confirmation [here]
(https://expensify.slack.com/archives/C01GTK53T8Q/p1729083871002409?thread_ts=1729070840.273779&cid=C01GTK53T8Q)
Status: Confirmed
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@hoangzinh |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-10-18.at.21.26.07.android.movAndroid: mWeb ChromeScreen.Recording.2024-10-18.at.21.29.33.android.chrome.moviOS: NativeScreen.Recording.2024-10-18.at.21.36.01.moviOS: mWeb SafariScreen.Recording.2024-10-18.at.21.31.58.ios.safari.movMacOS: Chrome / SafariScreen.Recording.2024-10-18.at.20.45.42.web.movMacOS: DesktopScreen.Recording.2024-10-18.at.21.22.32.desktop.mov |
src/pages/workspace/accounting/qbd/QuickBooksDesktopSetupPage.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.51-1 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.51-4 🚀
|
Details
[QBD] Restrict QBD to Control plans
Fixed Issues
$ #50704
PROPOSAL:
Tests
Prerequisites:
Offline tests
Prerequisites:
QA Steps
Prerequisites:
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
desktop.mov
MacOS: Desktop
web.mov