-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Allow support agents to unsubscribe on a user’s behalf via NewDot Supportal #50842
Comments
Triggered auto assignment to @alexpensify ( |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
@alexpensify - this is super easy to repro! just follow the steps outlined above to confirm you don't have the option to disable that setting while support logged in 👍 |
Yep, I can replicate this experience. |
Job added to Upwork: https://www.upwork.com/jobs/~021847125281120053453 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf ( |
@allgandalf—We need proposals here, but I've marked this as Heads up, I will be offline until Tuesday, October 22, 2024, and will not actively watch over this GitHub during that period.If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online. |
@m-natarajan Hi there. Could you please explain what means |
@alexpensify @maddylewis , Can you make a video of this bug with networks tab open? If you see a call to You can follow steps in the video below: Screen.Recording.2024-10-18.at.1.05.06.PM.mov |
Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue. |
cool! @narefyev91 can you start working, someone can assign you this soon :)) |
@narefyev91 did you find out the RCA here ? |
on it - but closely to add my research |
My findings so far: Screen.Recording.2024-10-22.at.13.55.50.movBut seems like i have some ideas why issue maybe happened in some rare case. In description in the issue it says that user should login as "Copilot" - but if that happened - user will see dropdown near the name (see images above). 8mb.video-hF1-Da4kNFwJ.mp4And existing one: Screen.Recording.2024-10-22.at.14.05.35.movAlso i tried with not verified account: Screen.Recording.2024-10-22.at.13.58.24.movWhich mean that now in current time FE and API is working fine. Screen.Recording.2024-10-22.at.14.19.38.movI see that fallback value was added just because isOn could not be undefined (that was done during re-writing Switch component to TS). My suggestion here - to remove that fallback and add optional isOn to TS type for Switch let me know your thoughts @allgandalf |
@narefyev91 i guess you mistook |
Well and how does support account is set to login to customer account? |
@maddylewis can you please help in here, I think it's from a different platform, hence i asked for network tag video in this comment, i will bump her on slack and C.c you @n |
In any case we have 2 possible issues here:
|
I feel 2. is the issue here, if the API return null then we would have seen it on the UI, I guess we have failureData there as well. Lets explore option 2 for now |
Yeah agree - fallback should be removed 100% |
I agree with your analysis and it makes sense to me ! I will also get an internal engineer involved to proceed with this bug. 🎀👀🎀 |
Triggered auto assignment to @chiragsalian, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
hey @chiragsalian , The bug is when someone Supportals into customer account, We are still waiting for the network tag API call from @maddylewis (IF you have access to supportal even you can help here) but overall, the RCA by @narefyev91 here makes sense to me as to why that remains on. How should we proceed here :) |
Okay cool, @narefyev91 @chiragsalian , when we supportal into an account and try to toggle the button, the API never gets called: Here are recordings with network tab on by @maddylewis : 2024-10-22_09-34-48.mp42024-10-22_09-17-09.mp4 |
API may not be called - if anything blocked API.write to be executed - like some permissions or something else |
Will dive deeper tomorrow - have some ideas to check. Will keep posted! |
Haven't investigated, but this part,
Sounds like a front end issue no 😛
I don't see copilot mentioned in the issue. Also to be clear, copilot and supportal and very different flows. |
BINGO!!!!, I wanted to see whether the API call is made or not, cause @maddylewis was OoO and I for obvious reasons cannot reproduce this.
is it? Do you have any example code where the action is blocked on ND for supportal? I can reference that to find the RCA |
Tested on staging. The API call is not made for me when i use supportal. I tested toggling "Receive relevant feature updates and Expensify news".
It was just my first guess. I looked around a little bit and found it here. So if we're using a supportal authtoken and its not a supportal request then no API call is made. The list of supported supportal actions are listed here ✌️ |
Damn!!!, okay so if we simply add the |
Yeah thanks @chiragsalian ! Ended up yesterday on exactly the same file as you mentioned - did not even know that we have separate logic to prevent API calls to be executed for customer support. Will create a fix PR soon |
yeah, even I didn't know that. just curious: @chiragsalian is this validation |
We have these checks on the BE as well. Its very easy to add BE support but yeah we need to test and confirm if any changes need to be back to the backend. When I'm testing the FE PR ill check and make changes if needed. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @maddylewis
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729018431544889
Action Performed:
Expected Result:
Actual Result: i cannot d
Expected Result:
Should be able to disable "receive relevant feature updates and expensify news" while support logged into a NewDot account
Actual Result:
Unable to disable "receive relevant feature updates and expensify news"
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
2024-10-14_09-25-42.mp4
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @allgandalfThe text was updated successfully, but these errors were encountered: