-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Expensify Card - "Add shipping details" button still appears when the card is deactivated #50693
Comments
Triggered auto assignment to @zanyrenney ( |
We think that this bug might be related to #wave-collect - Release 2 |
@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Edited by proposal-police: This proposal was edited at 2024-10-16 16:42:03 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue."Add shipping details" button still appears when the card is deactivated. What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional) |
Agreed, this button shouldn't be there! |
Job added to Upwork: https://www.upwork.com/jobs/~021846577574853745828 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh ( |
Hi, Here is my suggestion.
If we discuss more details about current issue and help me to check your codebase as soon, I can provide with better solution. |
📣 @SWS-5007! 📣
|
@SWS-5007 Thanks for your proposal. Please follow proposal template here https://github.com/Expensify/App/blob/main/contributingGuides/PROPOSAL_TEMPLATE.md |
@truph01's proposal looks good to me. Link to proposal #50693 (comment) 🎀👀🎀 C+ reviewed |
Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@hoangzinh, @jasperhuangg, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick! |
📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @truph01 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.48-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
"Add shipping details" button will not appear since the card is deactivated.
Actual Result:
"Add shipping details" button still appears when the card is deactivated.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6633297_1728811970050.20241013_172918.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @hoangzinhThe text was updated successfully, but these errors were encountered: