Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-30] Add RBR reason to LHN debugging #50665

Open
puneetlath opened this issue Oct 11, 2024 · 13 comments
Open

[HOLD for payment 2024-10-30] Add RBR reason to LHN debugging #50665

puneetlath opened this issue Oct 11, 2024 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@puneetlath
Copy link
Contributor

puneetlath commented Oct 11, 2024

As discussed here, let's add the reason a given report is showing an RBR in the LHN to the reports debug information. Similar to what we do for GBRs.

cc @pac-guerreiro

Issue OwnerCurrent Issue Owner: @puneetlath
@puneetlath puneetlath added Weekly KSv2 NewFeature Something to build that is a new item. labels Oct 11, 2024
Copy link

melvin-bot bot commented Oct 11, 2024

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Oct 11, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Oct 11, 2024

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

@pac-guerreiro
Copy link
Contributor

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

@pac-guerreiro
Copy link
Contributor

Hey, yesterday I opened a draft PR for this so you can see my progress while I work on this issue 😄

Here is what remains to be done:

  • Add RBR reason test cases in DebugUtilsTest.ts
  • Add screenshots
  • Add QA testing steps

@pac-guerreiro
Copy link
Contributor

Today's update:

  • Add RBR reason test cases in DebugUtilsTest.ts

Todo:

  • Fix unit test for when there are transaction thread violations
  • Add screenshots
  • Add QA testing steps

@puneetlath
Copy link
Contributor Author

Thanks for these updates!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Oct 17, 2024
@pac-guerreiro
Copy link
Contributor

The PR is now ready for review! 😄

Go ahead @DylanDylann

@pac-guerreiro
Copy link
Contributor

I just applied the suggested changes by @puneetlath and @DylanDylann.

The PR is ready for a new review 😄

@pac-guerreiro
Copy link
Contributor

The PR was finally merged 🙌

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 23, 2024
@melvin-bot melvin-bot bot changed the title Add RBR reason to LHN debugging [HOLD for payment 2024-10-30] Add RBR reason to LHN debugging Oct 23, 2024
Copy link

melvin-bot bot commented Oct 23, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 23, 2024
Copy link

melvin-bot bot commented Oct 23, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Oct 23, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
Development

No branches or pull requests

4 participants