-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hold for #49445][$250] Profile - The incorrect magic code sign is not displayed when wrong code is inserted #50653
Comments
Triggered auto assignment to @OfstadC ( |
Edited by proposal-police: This proposal was edited at 2023-10-06T15:45:00Z. ProposalPlease re-state the problem that we are trying to solve in this issue.When adding a new contact method (email), if the user enters an incorrect Magic code during the email verification step, no clear error message is displayed. Instead, the user is redirected to the next page without being informed that the Magic code was wrong. The expected behavior is to show a clear error message and prevent the user from moving forward. What is the root cause of that problem?As we are using addNewContactMethod action in the NewContactMethodPage:
As a result, the error object remains empty, and the user is redirected without seeing the error. What changes do you think we should make in order to solve the problem?
new.mov |
Testing now |
Job added to Upwork: https://www.upwork.com/jobs/~021846210499801072215 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.The error message that says "Failed to add the contact method" will be shown, but the exact error will not be visible to the user What is the root cause of that problem?We always navigate back to the list contact method page after we submit the magic code App/src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx Lines 59 to 65 in 2d9a28f
Another problem here is we added the But we get the error with
What changes do you think we should make in order to solve the problem?We should only navigate back to the list contact method page if we enter the correct magic code.
App/src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx Lines 59 to 65 in 2d9a28f
What alternative solutions did you explore? (Optional)For points 1 and 2 we can return the promise in App/src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx Lines 59 to 65 in 2d9a28f
|
@akinwale Could you review the proposals by Monday? Thank you! 😃 |
Since refactoring is currently taking place on the same files and they are implementing a different modal, I suggest we hold off on this issue until those changes are completed. |
@hungvu193 - looks like #49445 has been deployed. Do we need to do anything else for this issue? Or does that cover this fix? |
Verified it's fixed on Staging. We can close this issue 😄 Screen.Recording.2024-10-25.at.21.44.29.mov |
Thank youuu! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.48
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
An incorrect magic code sign is shown, allowing the user to easily identify the error and edit the magic code
Actual Result:
The error message that says "Failed to add the contact method" will be shown, but the exact error will not be visible to the user
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6623778_1727998570348.Bug_video_05.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @akinwaleThe text was updated successfully, but these errors were encountered: