-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Update second Allow location access
modal on web
#50601
Comments
Triggered auto assignment to @Christinadobrzyn ( |
Edited by proposal-police: This proposal was edited at 2024-10-17 18:30:45 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
if so, the App/src/components/LocationPermissionModal/index.tsx Lines 22 to 36 in 4c90d62
What changes do you think we should make in order to solve the problem?
App/src/components/LocationPermissionModal/index.tsx Lines 22 to 36 in 4c90d62
What alternative solutions did you explore? (Optional)Solution for new design:
App/src/components/LocationPermissionModal/index.tsx Lines 38 to 49 in 4c90d62
and prompt:
to match the new design:
It is very straightforward:
|
@jamesdeanexpensify We don't want to display the pre-prompt but still display the native prompt on web, no? |
Yes, we would still show the native prompt on web. Thanks! |
Edited by proposal-police: This proposal was edited at 2024-10-15 11:18:52 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Remove "Allow location access" modal on web What is the root cause of that problem?Feature request What changes do you think we should make in order to solve the problem?New Solution according to expected results:
And update the <ConfirmModal
onConfirm={(hasError && isWeb) ? skipLocationPermission : grantLocationPermission}
shouldShowCancelButton={!(hasError && isWeb)} These changes are enough to match the expected results in this case |
@jamesdeanexpensify @Julesssss In my opinion, I don’t think we can fully hide the modal Previously, when the user clicked the submit button and the native prompt hadn’t been shown yet, we displayed the pre-prompt modal: If the user chose 'Continue,' but location permission wasn’t granted, the native prompt wouldn’t appear in the future. That's why, the next time, we display a modal to inform them that they need to manually enable location permission: So, the 2nd modal should not be hidden. |
@Julesssss, @Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Thanks for the feedback @truph01! Sorry, just catching up here, can you confirm the difference you are proposing? I think it's that we only show the "Not Now"/"Got it" prompt on the web and not the pre-prompt? Is that right? |
Yes |
I think this makes sense - do you @Julesssss @jamesdeanexpensify? Do you think we need a consensus from the team about this? |
That seems to be what we agreed, but lets check in with James first. |
We're discussing this one internally and may recommend an alternative course of action. Stay tuned! |
Just for alignment purposes - by "native prompt" on web, are we all talking about the second screenshot here? |
Yes |
The video you attached is not being played, can you add another |
@jamesdeanexpensify this means that we only show the prompt on native devices right? |
Hmmm...that video is working for me. Here it is again: 2024-10-10_09-11-41.mp4And sorry, what do you mean by "only show the prompt on native devices"? |
|
Ah, that's super helpful! Bringing this back to the team to chat about next steps again. Thanks! |
OK, here is where we landed: On web only, for the second
2024-10-10_09-11-41.mp4 |
Allow location access
modal on web
Allow location access
modal on webAllow location access
modal on web
@jamesdeanexpensify so by only web we mean that there should be no change to the behaviour on native platforms right ? |
Can you explain a bit more what you mean by that? Just want to make sure I'm understanding, thanks! I'm not a BZ person so it's helpful. |
Thanks for asking, I got the context, i updated the proposal accordingly |
@Christinadobrzyn @Julesssss it looks like we have two proposals (here and here) to review, and I've updated the tasks in the OP up top! Quick note - we're not removing any modals now, only adjusting an existing one. |
Yeah, just web will change. |
Allow location access
modal on webAllow location access
modal on web
Job added to Upwork: https://www.upwork.com/jobs/~021847227311681373401 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov ( |
@Julesssss, @Christinadobrzyn, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@alitoshmatov can you please check out the proposals when you have a moment? TY! |
@Julesssss @Christinadobrzyn @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Hi @alitoshmatov, are you able to review? |
On web only, for the second
Allow location access
modal only (the one with theGot it
button):Got it
(see video below)Got it
button, the same button quickly flickers to sayContinue
(same video below)Not now
button entirely because it serves no purpose in this case2024-10-10_09-11-41.mp4
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @alitoshmatovThe text was updated successfully, but these errors were encountered: