-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$125] mWeb - Chat - When deleting mention in second line, suggestions overlap the message #50588
Comments
Triggered auto assignment to @twisterdotcom ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.When removing mention characters that makes the line reduces, the suggestion overlaps with the message. What is the root cause of that problem?The position of the suggestion is based on the invisible text here which renders value after caret ( App/src/components/Composer/index.tsx Lines 346 to 354 in e44ba87
The value after caret is updated on every selection change by taking the substring of the App/src/components/Composer/index.tsx Lines 119 to 126 in e44ba87
However, when the selection change is triggered, the
The invisible text will also be 2 line. Then removes the last What changes do you think we should make in order to solve the problem?We need to get the input value directly from the element just like what we did when calculating the value before caret. App/src/components/Composer/index.tsx Lines 123 to 126 in e44ba87
|
@twisterdotcom Huh... This is 4 days overdue. Who can take care of this? |
Niche, so making only 125. |
Job added to Upwork: https://www.upwork.com/jobs/~021846354279628509557 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk ( |
Upwork job price has been updated to $125 |
I couldn't reproduce it on Desktop Web, iOS mWeb and Android mWeb (v9.0.49-1) : Screen.Recording.2024-10-16.at.11.55.53.mov@lanitochka17 would you mind retesting? Thanks a lot. |
I think it's not repro anymore after #50711 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.47
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
When the user is deleting a mention displayed in second line, and this mention is moved to the first line of the message, the suggestion box should also be moved, so it doesn´t overlap the written message in compose box
Actual Result:
When the user is deleting a mention displayed on the second line of the compose box, and this mention is moved to the first line of the message, the suggestion box, is not moved and overlaps the message
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6618061_1727491687772.Mentions.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @brunovjkThe text was updated successfully, but these errors were encountered: