-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Held expense - Negative amount in the payment button when the unheld expense comes from self #50497
Comments
Triggered auto assignment to @stephanieelliott ( |
We think that this bug might be related to #wave-collect - Release 1 |
@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.The payment button shows negative amount. Error shows up when trying to pay the negative amount. What is the root cause of that problem?If any transaction is held, we display the unheld option first without checking whether the App/src/components/MoneyReportHeader.tsx Line 147 in 5d25b40
What changes do you think we should make in order to solve the problem?
Lines 7497 to 7499 in 5d25b40
App/src/components/MoneyReportHeader.tsx Line 147 in 5d25b40
App/src/components/MoneyReportHeader.tsx Line 406 in 5d25b40
Or we can add a App/src/components/MoneyReportHeader.tsx Line 176 in 5d25b40
App/src/components/MoneyReportHeader.tsx Line 161 in 5d25b40
We need to do the same fix in What alternative solutions did you explore? (Optional)If we don't want to return |
Job added to Upwork: https://www.upwork.com/jobs/~021844594617993665700 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale ( |
📣 @Jaytechent! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
@akinwale, @stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Thanks @Jaytechent! No, you should not need to fund the account. Did you |
^^ bump @akinwale |
@stephanieelliott Thanks for the bump. @mkzie2's proposal is adequate here. 🎀👀🎀 C+ reviewed. |
Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Hey @akinwale this PR is awaiting your review, can you take a look? |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.46-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The payment button will not have negative amount.
Actual Result:
The payment button shows negative amount. Error shows up when trying to pay the negative amount.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6629337_1728468290060.20241009_175957.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @akinwaleThe text was updated successfully, but these errors were encountered: