-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] keyboard hides unexpectedly when adding a new task on the report screen #50442
Comments
Triggered auto assignment to @johncschuster ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Tapping a task on the report screen while the soft keyboard is open will close the keyboard. What is the root cause of that problem?The soft keyboard is closed during the screen transition by the two pieces of code below. App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx Line 663 in 1c0d2fa
What changes do you think we should make in order to solve the problem?We don't need to pass the const isAndroidNative = getPlatform() === CONST.PLATFORM.ANDROID; App/src/components/Composer/index.native.tsx Line 127 in 1c0d2fa
autoFocus={isAndroidNative ? undefined : autoFocus} What alternative solutions did you explore? (Optional)We could consider disabling auto focus for the task details screen, just like we did for the money request details screen below. App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx Lines 302 to 307 in 1c0d2fa
|
@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Job added to Upwork: https://www.upwork.com/jobs/~021844835682397684717 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
@johncschuster, @mollfpr Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Looks like we're still waiting on proposals |
Bump for Melv |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@allgandalf can you take a look at @QichenZhu's proposal and let me know if it's sufficient? If not, I'll drum up more proposals! |
@johncschuster Do you mean me? 😅 I'll review the latest proposal! |
@johncschuster @mollfpr this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
.... 🤦 .... yes. Sorry about that! Did you get a chance to review the latest proposal? |
@QichenZhu to be clear the Also, why do we still need the |
I repro the issue a while ago, but after pulling the latest Screen_Recording_20241025_201335_New.Expensify.Dev.mov |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.46-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1728308186934659
Action Performed:
Expected Result:
Keyboard should remain open when viewing the task details.
Actual Result:
Composer is shown as active, but the keyboard is hidden.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Android.keyboard.mp4
az_recorder_20241008_131240.1.mp4
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: