[HOLD for payment 2024-10-17] mWeb - Option in onboarding guided flow is not based on sign up's choice

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.45-2
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #47619
Issue reported by: Applause Internal Team

Action Performed:

1. Navigate to staging.expensify.com
2. choose "Organize my own expenses"
3. Enter a new account
4. Click on Sign up
5. Click on join

Expected Result:

Onboarding modal is only limited to "Track and budget expenses", "Get paid back by my employer", "Chat and split bills with friends".

Actual Result:

Onboarding modal contains 'Manage my team's expenses' and 'Something else'.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6625690_1728152152202.video_2024-10-05_02-02-54.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[carlosmiceli]

I'll take this one since it's onboarding related.

[carlosmiceli]

@IuliiaHerets could you show me the URL where you're being redirected after signing up? That'll help me know if it's a FE or BE issue.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[ChavdaSachin]

Same RCA as #50299
Proposal here

[twilight2294]

My PR fixed this issue too, am i eligible for payment on this issue too?

[carlosmiceli]

I'm not sure, I'll let @mallenexpensify tell us that. Matt, happy to explain whatever you think is necessary to make a decision about this.

[mallenexpensify]

Breaking things down a bit

• @twilight294 submits proposal and is hired for [HOLD for payment 2024-10-17] [$250] mWeb - Continue button does not work in onboarding modal #50299
• @twilight294 created PR - Fix: Continue button does not work in onboarding modal #50359
• That PR also fixes this bug.

Assuming so, let's wait for the PR to be on production for 7 days then we'll continue discussing.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[allgandalf]

Note

^ False Flag, I reverted our PR and tested it out, but the issue still occurs, details here , so not a regression from our end

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.47-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Continue button does not work in onboarding modal #50359

If no regressions arise, payment will be issued on 2024-10-17. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@carlosmiceli] The PR that introduced the bug has been identified. Link to the PR: Adjust the Guided Setup Flow based on user's Sign Up Qualifier #47619
• [@carlosmiceli] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Adjust the Guided Setup Flow based on user's Sign Up Qualifier #47619 (comment)
• [@carlosmiceli] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this was covered in the list of test steps provided to QA afterwards.
• [@carlosmiceli] Determine if we should create a regression test for this bug.
• [@carlosmiceli] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[twilight2294]

Hey, this is ready for payment tomorrow, my upwork is: https://www.upwork.com/freelancers/~012449dd63a43050f7

If my profile is not visible by the time of payment please hold 1 day, after i received payment yesterday upwork asked me for ID verification, something happened and they started manual verification of my profile and put ID on hold, but now it's completed and they say that my profile will be visible in 24 hours:

EDIT: My profile is now visible, can you make an offer to me please @mallenexpensify 😄

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[mallenexpensify]

@twilight2294 , there are a few considerations here.

1. We don't have a process where we compensate more if a PR fixes other bugs/issues. If additional work is invested in the PR for the other issue, to fix this one, please document and link to the additional work
2. This issue never had the Help Wanted label on it so it was never a 'job'
3. We do have "If you think your compensation should be increased for a specific job, you can request a reevaluation by commenting in the Github issue where the Upwork job was posted." in CONTRIBUTING.md so you could comment on [HOLD for payment 2024-10-17] [$250] mWeb - Continue button does not work in onboarding modal #50299 and request additional compensation (but, in this instance, since I'm the one helping with both, posting there likely wouldn't lead to additional compensation since we're hashing this out here).