[P2P Distance] Rate currency doesn't match expense currency #50142

nyomanjyotisa · 2024-10-03T10:41:04Z

Details

Fixed Issues

$ #46844
PROPOSAL: #46844 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Pre-requisites:
Have 2 accounts with different personal currencies.
For this:

Log in to OD as User A
Go to Settings > Workspaces > Individual
Select your personal workspace
Select "Reports" from the left menu
Change the report currency to EUR
For User B, keep the default currency (e.g. USD)

Test 1:

Login as User A and User B to ND on different devices;
As User A, submit a Distance request to User B
As User A, navigate to the created request details
Verify its amount and rate are displayed in EUR
As User B, navigate to the same distance request details
Verify its amount and rate are displayed in EUR
As User B, submit a Distance request to User A
As User B, navigate to the created request details
Verify its amount and rate are displayed in USD
As User A, navigate to the same distance request details
Verify its amount and rate are displayed in USD

Test 2:

Submit a Distance request
Navigate to the created request details
Verify its rate is displayed as the selected policy currency
Go to the workspace setting and change the default currency to another currency (e.g. EUR)
Navigate to the created request details
Click on the "Rate" field
Verify that the rate shown in the "Rate" field matches the rate displayed in the "Selected Rate" modal

PR Author Checklist

Screenshots/Videos

Android: Native

Test 1

User A

User B

Test 2

Android-Native.mp4

Android: mWeb Chrome

Test 1

User A

User B

Test 2

Android-mWeb.Chrome.mp4

iOS: Native

Test 1

User A

User B

Test 2

iOS-Native.mp4

iOS: mWeb Safari

Test 1

User A

User B

Test 2

iOS-mWeb.Safari.mp4

MacOS: Chrome / Safari

Test 1

User A

User B

Test 2

MacOS-Chrome.mp4

MacOS: Desktop

Test 1

User A

User B

Test 2

MacOS-Desktop.mp4

nyomanjyotisa · 2024-10-03T13:24:25Z

Hi @paultsimura

I can't create a p2p distance request to test this changes, have override the canUseAllBetas to return true, but it always return the following error

{
    "code": 666,
    "jsonCode": 666,
    "type": "Expensify\\Libs\\Error\\ExpError",
    "UUID": "80ADBEDB-6248-4C16-B2EA-85E03A744715",
    "message": "An unexpected error occurred, please try again. If the error persists, please reach out to [email protected].",
    "title": "",
    "data": {
        "onyxData": [
            {
                "onyxMethod": "merge",
                "key": "transactions_3741292594858687845",
                "value": {
                    "errors": {
                        "1727961374732808": "An unexpected error occurred, please try again. If the error persists, please reach out to [email protected]."
                    }
                }
            }
        ]
    },
    "htmlMessage": "",
    "onyxData": [
        {
            "onyxMethod": "merge",
            "key": "transactions_3741292594858687845",
            "value": {
                "errors": {
                    "1727961374732808": "An unexpected error occurred, please try again. If the error persists, please reach out to [email protected]."
                }
            }
        }
    ],
    "requestID": "8ccd347c3e89b5b1-CGK"
}

Recording:

-1-New-Expensify.27.mp4

Any thoughts on this?

paultsimura · 2024-10-03T13:39:29Z

@nyomanjyotisa this is weird 🤔
Are you doing it between 2 completely fresh accounts?

paultsimura · 2024-10-03T16:50:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

2024-10-03.-.19.11.-.android.mp4

Android: mWeb Chrome

2024-10-03.-.19.11.-.chrome.mp4

iOS: Native

2024-10-03.-.19.11.-.Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-03.at.19.00.31.mp4

iOS: mWeb Safari

2024-10-03.-.19.11.-.Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-03.at.19.01.19.mp4

MacOS: Chrome / Safari

MacOS: Desktop

2024-10-03.-.19.11.-.Screen.Recording.2024-10-03.at.18.57.38.mp4

melvin-bot · 2024-10-03T17:04:43Z

@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nyomanjyotisa · 2024-10-03T17:05:46Z

@paultsimura ready for review, need to test it between 2 completely fresh accounts

paultsimura · 2024-10-03T17:35:21Z

@nyomanjyotisa could you please change the testing steps in the description to these?

Pre-requisites:
Have 2 accounts with different personal currencies.
For this:

Log in to OD as User A
Go to Settings > Workspaces > Individual
Select your personal workspace
Select "Reports" from the left menu
Change the report currency to EUR
For User B, keep the default currency (e.g. USD)

Test:

Login as User A and User B to ND on different devices;
As User A, submit a Distance request to User B
As User A, navigate to the created request details
Verify its amount and rate are displayed in EUR
As User B, navigate to the same distance request details
Verify its amount and rate are displayed in EUR
As User B, submit a Distance request to User A
As User B, navigate to the created request details
Verify its amount and rate are displayed in USD
As User A, navigate to the same distance request details
Verify its amount and rate are displayed in USD

Note: Also, please remove the "Verify that no errors appear in the JS console" at the end – it's redundant here.

paultsimura

LGTM ✔️

paultsimura · 2024-10-04T07:11:31Z

@neil-marcellini all yours.

neil-marcellini

Let's use TransactionUtils.getCurrency instead since it accounts for modifiedCurrency.

Could we please also include a test step to click into the rate field and make sure the currencies show there properly? For example if I create a request with the policy report currency as USD and on a policy with several rates, then change the report currency to EUR, then go to edit the distance rate I think it will show the currently selected rate in EUR, when it should be USD, and all other rates should show as EUR. We need to get the rate currency for the currently selected rate from the transaction vs the policy.

You can check out this draft PR where I'm doing something similar for the distance unit.

paultsimura · 2024-10-04T19:10:30Z

Let's use TransactionUtils.getCurrency instead since it accounts for modifiedCurrency.

This is exactly why I suggested using transactionCurrency – it is build via TransactionUtils.getCurrency inside the ReportUtils.getTransactionDetails:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 114 to 126 in 5e39861

    
           const { 
        
               created: transactionDate, 
        
               amount: transactionAmount, 
        
               taxAmount: transactionTaxAmount, 
        
               currency: transactionCurrency, 
        
               comment: transactionDescription, 
        
               merchant: transactionMerchant, 
        
               billable: transactionBillable, 
        
               category: transactionCategory, 
        
               tag: transactionTag, 
        
               originalAmount: transactionOriginalAmount, 
        
               originalCurrency: transactionOriginalCurrency, 
        
           } = useMemo<Partial<TransactionDetails>>(() => ReportUtils.getTransactionDetails(transaction) ?? {}, [transaction]);

App/src/libs/ReportUtils.ts

Line 2958 in 60afa5e

currency: TransactionUtils.getCurrency(transaction),

paultsimura · 2024-10-04T20:11:00Z

@neil-marcellini, regarding your testing scenario – I think it already works as expected (please check the recording). The only thing is that when you click the "rate" field to modify it, one of them is highlighted (because the mapping is done by ID, which doesn't change) when it already shows a different currency in the selection list. However, I don't think it's quite related to this GH 🤔

2024-10-04.-.22.07.-.Screen.Recording.2024-10-04.at.22.06.36.mp4

neil-marcellini · 2024-10-07T17:08:33Z

@paultsimura Yes, so in the video you showed above the problem is that the currency of the rate shows in EUR on the rate editor page, but it shows in USD on the transaction view. Let's fix that by getting the rate currency from the transaction for the currently selected rate.

I suppose it is a little confusing given that a rate in that currency doesn't exist on the policy, but I think that's less confusing than having a discrepancy between the transaction and the selected rate. The main goal is that existing distance expenses are not edited retroactively when the policy distance unit changes. If users complain or get confused then maybe we can include some informational text or re-think the pattern.

Additionally, I think we should change the prompt text on the rate editor to be unit agnostic, like I did here.

paultsimura · 2024-10-07T18:07:04Z

@nyomanjyotisa would you be able to handle this change request?

…xt agnostic

nyomanjyotisa · 2024-10-08T12:22:08Z

I have created a commit to handle this change request, could you please review? @paultsimura

-1-New-Expensify.28.mp4

Also, I got this lint error error 'withOnyx' is deprecated. Use useOnyxinstead ofwithOnyx whenever possible. should we fix it here? seems not related

paultsimura · 2024-10-08T12:42:57Z

Also, I got this lint error error 'withOnyx' is deprecated. Use useOnyxinstead ofwithOnyx whenever possible. should we fix it here?

Yes, this is a new requirement: https://expensify.slack.com/archives/C01GTK53T8Q/p1726169039084589

paultsimura

Minor changes 🙏

src/languages/en.ts

src/languages/es.ts

paultsimura · 2024-10-08T13:26:56Z

@nyomanjyotisa please add another test to the PR description.
Separate them as Test 1 and Test 2.
Cover the steps for submitting a request in one currency, then changing the policy currency, and verifying the rate is displayed the same in both "Rate" field value and the "Select rate" modal.

nyomanjyotisa · 2024-10-08T15:19:46Z

PR description and test updated @paultsimura

paultsimura · 2024-10-08T15:20:25Z

@nyomanjyotisa another bug:

Open the App on different devices (or in multiple tabs)
On device A, start creating a Distance request to your workspace (which uses USD as a currency)
On the Confirmation page, click "Rate" to open the list of distance rates
On device B, change the workspace currency to EUR
Go back to device A

Expected: the selected rate currency is changed to EUR
Actual: the selected rate currency still shows USD

Place the request
While it's still pending the BE response, check the money request preview

Expected: the request amount shows currency: EUR
Actual: the request amount shows currency USD until the response comes and changes it to EUR

2024-10-08.-.17.08.-.Screen.Recording.2024-10-08.at.16.57.44.mp4

paultsimura · 2024-10-09T08:58:36Z

@nyomanjyotisa regarding this – my guess is we should update the draft transaction's currency when the rate currency changes during the creation flow.

paultsimura · 2024-10-09T15:35:40Z

@nyomanjyotisa a potential fix is to change this line by adding || prevCurrency !== currency:

App/src/components/MoneyRequestConfirmationList.tsx

Line 295 in bb47985

    
           const shouldCalculateDistanceAmount = isDistanceRequest && (iouAmount === 0 || prevRate !== rate || prevDistance !== distance);

const shouldCalculateDistanceAmount = isDistanceRequest && (iouAmount === 0 || prevRate !== rate || prevDistance !== distance || prevCurrency !== currency);

nyomanjyotisa · 2024-10-10T16:20:49Z

@nyomanjyotisa a potential fix is to change this line by adding || prevCurrency !== currency:

App/src/components/MoneyRequestConfirmationList.tsx

Line 295 in bb47985

const shouldCalculateDistanceAmount = isDistanceRequest && (iouAmount === 0 || prevRate !== rate || prevDistance !== distance);
const shouldCalculateDistanceAmount = isDistanceRequest && (iouAmount === 0 || prevRate !== rate || prevDistance !== distance || prevCurrency !== currency);

@paultsimura Thanks, I'll try and test this out today

paultsimura · 2024-10-10T16:50:11Z

Let's also hold for #50532 as we'll be changing MoneyRequestConfirmationList and it will require the withOnyx migration, which is quite complex.

…anges

src/components/MoneyRequestConfirmationList.tsx

paultsimura · 2024-10-11T19:06:04Z

The code looks good and tests well. We should hold for #50532 for the CI. However, it hasn't been C+ reviewed for five days now.
Alternatively, we could make the migration in this PR, but IMO it should be eligible for a bounty bump as it's now a separate external issue worth $250 and the migration is quite complex with a component memo wrapper involved.

WDYT @neil-marcellini?
Also, @nyomanjyotisa would you be ok with implementing such a change?

nyomanjyotisa · 2024-10-14T04:45:29Z

It would be fine for me to implement the change, @paultsimura. Should we implement it directly in this PR?

paultsimura · 2024-10-14T07:04:42Z

It would be fine for me to implement the change, @paultsimura. Should we implement it directly in this PR?

I think we should wait for @neil-marcellini decision on #50142 (comment).

neil-marcellini

I think the code looks fine and since C+ says it tests well we can go ahead and merge. We don't need to wait for the MoneyRequestConfirmationList refactor since that's a separate thing. I'll bump that one along too.

@nyomanjyotisa we need to fix merge conflicts though. Please message me on Slack when it's updated so I can merge quickly.

nyomanjyotisa · 2024-10-16T02:53:20Z

Conflict resolved @neil-marcellini

neil-marcellini · 2024-10-16T15:33:54Z

Changed files check is being addressed with [$250] Migrate MoneyRequestConfirmationList to useOnyx and other issues.

melvin-bot · 2024-10-16T15:34:05Z

@neil-marcellini looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-10-16T15:43:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-17T01:58:59Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-18T18:47:49Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.50-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[P2P Distance] Rate currency doesn't match expense currency

c95e5e9

nyomanjyotisa marked this pull request as ready for review October 3, 2024 17:04

nyomanjyotisa requested a review from a team as a code owner October 3, 2024 17:04

melvin-bot bot requested review from paultsimura and removed request for a team October 3, 2024 17:04

paultsimura approved these changes Oct 3, 2024

View reviewed changes

melvin-bot bot requested a review from neil-marcellini October 3, 2024 17:53

neil-marcellini mentioned this pull request Oct 4, 2024

Use transaction distanceUnit to prevent retroactive changes #50001

Merged

50 tasks

neil-marcellini requested changes Oct 4, 2024

View reviewed changes

nyomanjyotisa added 2 commits October 8, 2024 20:17

set the selected rates to the transaction currency and make prompt te…

9136e8a

…xt agnostic

lint fix

b5e86a3

migrate to useOnyx

5a7ada0

paultsimura suggested changes Oct 8, 2024

View reviewed changes

src/languages/en.ts Outdated Show resolved Hide resolved

src/languages/es.ts Outdated Show resolved Hide resolved

minor fix

36a4e27

update the selected currency on rate modal when workspace currency ch…

7f557e0

…anges

paultsimura suggested changes Oct 11, 2024

View reviewed changes

src/components/MoneyRequestConfirmationList.tsx Outdated Show resolved Hide resolved

minor fix

3a08cff

paultsimura approved these changes Oct 11, 2024

View reviewed changes

melvin-bot bot requested a review from neil-marcellini October 11, 2024 19:01

neil-marcellini previously approved these changes Oct 15, 2024

View reviewed changes

Merge branch 'main' into issue-46844

89e5a09

nyomanjyotisa dismissed neil-marcellini’s stale review via 89e5a09 October 16, 2024 02:00

neil-marcellini approved these changes Oct 16, 2024

View reviewed changes

neil-marcellini merged commit 336c2dd into Expensify:main Oct 16, 2024
16 of 17 checks passed

melvin-bot bot added the Emergency label Oct 16, 2024

neil-marcellini removed the Emergency label Oct 16, 2024

github-actions bot mentioned this pull request Oct 17, 2024

Deploy Checklist: New Expensify 2024-10-17 #50969

Closed

90 tasks

melvin-bot bot mentioned this pull request Oct 18, 2024

[HOLD for payment 2024-10-25] [$250][P2P Distance] Rate currency doesn't match expense currency #46844

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[P2P Distance] Rate currency doesn't match expense currency #50142

[P2P Distance] Rate currency doesn't match expense currency #50142

nyomanjyotisa commented Oct 3, 2024 •

edited

Loading

nyomanjyotisa commented Oct 3, 2024

paultsimura commented Oct 3, 2024

paultsimura commented Oct 3, 2024 •

edited

Loading

melvin-bot bot commented Oct 3, 2024

nyomanjyotisa commented Oct 3, 2024

paultsimura commented Oct 3, 2024 •

edited

Loading

paultsimura left a comment

paultsimura commented Oct 4, 2024

neil-marcellini left a comment

paultsimura commented Oct 4, 2024

paultsimura commented Oct 4, 2024

neil-marcellini commented Oct 7, 2024

paultsimura commented Oct 7, 2024

nyomanjyotisa commented Oct 8, 2024 •

edited

Loading

paultsimura commented Oct 8, 2024 •

edited

Loading

paultsimura left a comment

paultsimura commented Oct 8, 2024

nyomanjyotisa commented Oct 8, 2024

paultsimura commented Oct 8, 2024

paultsimura commented Oct 9, 2024

paultsimura commented Oct 9, 2024

nyomanjyotisa commented Oct 10, 2024

paultsimura commented Oct 10, 2024

paultsimura commented Oct 11, 2024 •

edited

Loading

nyomanjyotisa commented Oct 14, 2024

paultsimura commented Oct 14, 2024

neil-marcellini left a comment

nyomanjyotisa commented Oct 16, 2024

neil-marcellini commented Oct 16, 2024

melvin-bot bot commented Oct 16, 2024

OSBotify commented Oct 16, 2024

github-actions bot commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

[P2P Distance] Rate currency doesn't match expense currency #50142

[P2P Distance] Rate currency doesn't match expense currency #50142

Conversation

nyomanjyotisa commented Oct 3, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

nyomanjyotisa commented Oct 3, 2024

paultsimura commented Oct 3, 2024

paultsimura commented Oct 3, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Oct 3, 2024

nyomanjyotisa commented Oct 3, 2024

paultsimura commented Oct 3, 2024 • edited Loading

paultsimura left a comment

Choose a reason for hiding this comment

paultsimura commented Oct 4, 2024

neil-marcellini left a comment

Choose a reason for hiding this comment

paultsimura commented Oct 4, 2024

paultsimura commented Oct 4, 2024

neil-marcellini commented Oct 7, 2024

paultsimura commented Oct 7, 2024

nyomanjyotisa commented Oct 8, 2024 • edited Loading

paultsimura commented Oct 8, 2024 • edited Loading

paultsimura left a comment

Choose a reason for hiding this comment

paultsimura commented Oct 8, 2024

nyomanjyotisa commented Oct 8, 2024

paultsimura commented Oct 8, 2024

paultsimura commented Oct 9, 2024

paultsimura commented Oct 9, 2024

nyomanjyotisa commented Oct 10, 2024

paultsimura commented Oct 10, 2024

paultsimura commented Oct 11, 2024 • edited Loading

nyomanjyotisa commented Oct 14, 2024

paultsimura commented Oct 14, 2024

neil-marcellini left a comment

Choose a reason for hiding this comment

nyomanjyotisa commented Oct 16, 2024

neil-marcellini commented Oct 16, 2024

melvin-bot bot commented Oct 16, 2024

OSBotify commented Oct 16, 2024

github-actions bot commented Oct 17, 2024

github-actions bot commented Oct 18, 2024

nyomanjyotisa commented Oct 3, 2024 •

edited

Loading

paultsimura commented Oct 3, 2024 •

edited

Loading

paultsimura commented Oct 3, 2024 •

edited

Loading

nyomanjyotisa commented Oct 8, 2024 •

edited

Loading

paultsimura commented Oct 8, 2024 •

edited

Loading

paultsimura commented Oct 11, 2024 •

edited

Loading