[$250] Paying an iouReport elsewhere on NewDot includes a bunch of junk in the email about consumer payments

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.40.2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727345244884739

Action Performed:

1. [Member] Submit an expense on a workspace
2. [Admin] Click 'pay elsewhere' to pay the report.

Expected Result:

The email sent on payment of the expense report doesn't include all the disclaimers for consumer payments because this iouReport was not paid with Expensify via the wallet.

Actual Result:

The email received includes all the junk about consumer payments in the footer.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021839397950883214755
• Upwork Job ID: 1839397950883214755
• Last Price Increase: 2024-10-03

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021839397950883214755

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@johncschuster, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[johncschuster]

Waiting on proposals

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[johncschuster]

I'm looking for the project this fits into and will drum up some proposals based on priority

[melvin-bot]

@johncschuster, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sobitneupane]

Waiting on proposals

[teneeto]

Hey! I'm Eto Olei from Callstack. I will like to take a look at this issue. Please assign it to me. Thanks!

[johncschuster]

Previously, I would have put this one into vip-vsb, but it seems like those issues are mostly being moved into newdot-quality, so I'm putting this in that project.

[teneeto]

Ok, BTW already started looking into this - I'm still trying to get familiar with the email notification flow basically, at least understand were such notifications are triggered, and then dig in properly why we have junks included in the email.

[teneeto]

Can we take a look at this from BE side, these messages seem to be sent from there.

[melvin-bot]

@johncschuster @teneeto @sobitneupane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[sobitneupane]

Thanks @teneeto. Looks like a BE issue to me as well.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[johncschuster]

Looks like this is a BE issue. @luacmartins, do you have space for this one?

[luacmartins]

My plate is quite full, so if we could get someone else to work on it that'd be great. Otherwise, I'll take a look at it some time next week.

[trjExpensify]

@blimpich, perhaps you could help here? It seems like we added all the consumer payments disclaimer stuff to an iouReport that's not actually paid in the product.

[blimpich]

I can look into it tomorrow 👍

[blimpich]

PR up, in review

[johncschuster]

Looks like this issue was handled completely by internal engineers. Does this require a payment summary?

[blimpich]

Nope, no payment summary needed 👍