[HOLD for payment 2024-10-30] [CRI] [Search v2.2] Add No category and No tag search filters

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.39-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: customer in the NewDot feedback public room.
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1727216730118619

Action Performed:

1. Create a workspace
2. Enable tags in More features > add a couple of tags
3. Go to the Search page
4. Create an expense
5. Click the Filters button
6. Click category
7. Click tag

Actual results

• It's not uncommon for people to want to filter their expense list to those they've yet to code properly, this helps them focus on what still needs to be done to finalise their expenses. On OldDot we accommodate this by including options for Uncategorized and Untagged in the filters on the expenses page. We didn't add those to NewDot with the MVP, and so this is a feature request issue to add those two filters.

Expected results

• When you click the Category filter, there should be a No category row at the top above the Category subheader. When selected, it filters the results to include expenses with no category value selected.

• When you click the Tag filter, there should be an No tag row at the top above the Tag subheader. When selected, it filter the results to include expenses with no tag value selected.

• We use no: in the search syntax for this. I.e no:category || no:tag

Workaround:

Yes, use OldDot to filter, but we really don't want them to switch back to Classic.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

[trjExpensify]

Put this on planning for a sec and assigned it to us @luacmartins while we just confirm on the Q here: https://expensify.slack.com/archives/C036QM0SLJK/p1727219750037359?thread_ts=1727216730.118619&cid=C036QM0SLJK

[JmillsExpensify]

I'm not sure this should be Uncategorized and Untagged given that we know we have customers that use Uncategorized.

[trjExpensify]

Why not? We've used that for years above the list of categories in the filters? I think that's fine.

[trjExpensify]

We could name the rows "No category" and "No tag" if we want? It would match the search syntax of no:category. I'm down for whatever.

[luacmartins]

I'm cool with matching the syntax and using No category or No tag

[JmillsExpensify]

Awesome that resolves my concern.

[trjExpensify]

Updated!

[trjExpensify]

You have everything you need here now to proceed, @luacmartins?

[luacmartins]

Yea, I think I have everything for now

[luacmartins]

Working on the draft PRs

[luacmartins]

PRs in review

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[ikevin127]

@luacmartins Just wanted to get some clarity on whether the regression was caused by FE and testing or comes from BE given the context mentioned in #50122 (comment). Was I missing something when I tested the PR here ?

I know the PR was reverted so if the error was on my part and it was 100% FE related then it would make sense that no payment is due here for reviweing the reverted PR. What's your take on what happened ?

Will jump on reviewing the v2 PR once the auth PR is deployed and HOLD is lifted 👍

[luacmartins]

There were two issues:

1. No category and No tag options weren't persisted once we selected View results and opened the page again. That was 100% frontend and fixed on this commit
2. The issue of returning no tags was in the backend, but we could have easily caught that while testing.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Support empty value for categories and tags #50122

If no regressions arise, payment will be issued on 2024-10-25. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[ikevin127]

No payment due here based on #49675 (comment) because the PR was reverted due to regression.

[trjExpensify]

Will jump on reviewing the v2 PR once the auth PR is deployed and HOLD is lifted 👍

Auth PR hit prod an hour ago: https://github.com/Expensify/Auth/pull/12812#issuecomment-2427681049

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Support empty value for categories and tags v2 #51033

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.