-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$125] The "Date" options for Report Fields are ambiguous and should be updated #49668
Comments
Triggered auto assignment to @twisterdotcom ( |
Job added to Upwork: https://www.upwork.com/jobs/~021838707744772503856 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane ( |
Edited by proposal-police: This proposal was edited at 2024-09-24 22:42:44 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.The "Date" options for Report Fields are ambiguous and should be updated What is the root cause of that problem?The value is
What changes do you think we should make in order to solve the problem?
App/src/libs/WorkspaceReportFieldUtils.ts Lines 82 to 84 in e232163
What alternative solutions did you explore? (Optional)
What alternative solutions did you explore? (Optional) 2If we want to show the date value instead of
Result |
I'll be the BZ for this issue so I'll unassign @twisterdotcom |
Upwork job price has been updated to $125 |
This should be a very simple fix, so I'm reducing the bounty on this one |
Proposal Updated
|
Edited by proposal-police: This proposal was edited at 2024-09-25 00:10:10 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.The "Date" options for Report Fields are ambiguous and should be updated What is the root cause of that problem?Feature request What changes do you think we should make in order to solve the problem?Instead of using
We can do something like this
Optional: We can remove this code block App/src/libs/WorkspaceReportFieldUtils.ts Lines 82 to 84 in 06a59ad
We might also need to do some cleanup What alternative solutions did you explore? (Optional)We can also fallback here to
|
Chris Your proposal will be dismissed because you did not follow the proposal template. |
Proposal Updated
|
ProposalPlease re-state the problem that we are trying to solve in this issue.The "Date" options for Report Fields are ambiguous and should be updated What is the root cause of that problem?New Feature request What changes do you think we should make in order to solve the problem?we need to change the description value to description={!isDateFieldType ? translate('common.initialValue') : translate('common.date')}.
What alternative solutions did you explore? (Optional) |
@rushatgabhane, @VictoriaExpensify Eep! 4 days overdue now. Issues have feelings too... |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@rushatgabhane, @VictoriaExpensify Still overdue 6 days?! Let's take care of this! |
@rushatgabhane can you please review these proposals and recommend one? |
1 similar comment
@rushatgabhane can you please review these proposals and recommend one? |
Not overdue |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@rushatgabhane @VictoriaExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@Krishna2323's proposal LGTM |
🎀 👀 🎀 |
Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Thanks @rushatgabhane @Krishna2323 - let's move forward with your proposal |
📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Will raise the PR today. |
PR will be raised soon |
@Julesssss, @rushatgabhane, @VictoriaExpensify, @Krishna2323 Eep! 4 days overdue now. Issues have feelings too... |
@VictoriaExpensify @Julesssss, should we also change the
We can change the field description from Monosnap.screencast.2024-10-16.00-03-06.mp4 |
That seems good to me. Any thoughts @VictoriaExpensify? |
@VictoriaExpensify, friendly bump. |
@VictoriaExpensify bump ^ |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.38-4 (9.0.38-4)
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856 - N/A
Expensify/Expensify Issue URL: Related to a resource update
Issue reported by: [email protected]
Slack conversation: https://expensify.slack.com/archives/C06ML6X0W9L/p1726634542759669
Action Performed:
Break down in numbered steps:
When you do this, the sub-category shown for date is "Current Date". This is ambiguous and confusing for a report field (is the Current Date the date the report was created? Submitted? Does it change?). This should be more clear.
As discussed here, we still want to show the
Date
sub option, but this should be changed fromcurrent date
toInitial value
.Since this should be a very simple change, I'm reducing the bounty to $125
Expected Result:
Describe what you think should've happened
Actual Result:
Describe what actually happened
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @rushatgabhaneThe text was updated successfully, but these errors were encountered: