[$125] The "Date" options for Report Fields are ambiguous and should be updated

[VictoriaExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.38-4 (9.0.38-4)
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856 - N/A
Expensify/Expensify Issue URL: Related to a resource update
Issue reported by: [email protected]
Slack conversation: https://expensify.slack.com/archives/C06ML6X0W9L/p1726634542759669

Action Performed:

Break down in numbered steps:

1. Navigate to the Settings for any Control Workspace
2. If you do not have the Report Fields option, enable this by going to More Features > Toggle on Report Fields
3. Click on Report Fields and select "Add Field"
4. Click "Type" and select "Date"

When you do this, the sub-category shown for date is "Current Date". This is ambiguous and confusing for a report field (is the Current Date the date the report was created? Submitted? Does it change?). This should be more clear.

As discussed here, we still want to show the Date sub option, but this should be changed from current date to Initial value.

Since this should be a very simple change, I'm reducing the bounty to $125

Expected Result:

Describe what you think should've happened

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021838707744772503856
• Upwork Job ID: 1838707744772503856
• Last Price Increase: 2024-10-08
• Automatic offers:
• Krishna2323 | Contributor | 104352795

Issue Owner

Current Issue Owner: @rushatgabhane

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021838707744772503856

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-09-24 22:42:44 UTC.

Proposal


Please re-state the problem that we are trying to solve in this issue.

The "Date" options for Report Fields are ambiguous and should be updated

What is the root cause of that problem?

The value is common.currentDate.

App/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx

Line 172 in e232163

title={translate('common.currentDate')}

What changes do you think we should make in order to solve the problem?


• We should change it to common.initialValue.
• Same should be done in getReportFieldInitialValue function.

App/src/libs/WorkspaceReportFieldUtils.ts

Lines 82 to 84 in e232163

	if (reportField.type === CONST.REPORT_FIELD_TYPES.DATE) {
	return Localize.translateLocal('common.currentDate');
	}

• We should also check in other places.

What alternative solutions did you explore? (Optional)

• In ReportFieldsSettingsPage, we might need to add a new field for date if we are going to change getReportFieldInitialValue because the description & title will be the same. So we might need to add a new MenuItemWithTopDescription in ReportFieldsSettingsPage for date field. Like we do in CreateReportFieldsPage.
• Or we can change the desctiption value to description={!isDateFieldType ? translate('common.initialValue') : translate('common.date')}.
  

  App/src/pages/workspace/reportFields/ReportFieldsSettingsPage.tsx

  Line 116 in 06a59ad

  description={translate('common.initialValue')}

What alternative solutions did you explore? (Optional) 2

If we want to show the date value instead of Initial value text, we can:

• Update the title to title={DateUtils.extractDate(subDays(new Date(), 1).toISOString()) ?? translate('common.currentDate')} and update the description to translate('common.initialValue') if required.
• We can also get the date according to the location if needed, then we can remove the subDays part. I believe the date value is set according to the US timezone.
  

  App/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx

  Line 172 in a7a0c53

  title={translate('common.currentDate')}

• Update getReportFieldInitialValue to return the default value instead of Localize.translateLocal('common.currentDate'). Should be updated to reportField.defaultValue ?? Localize.translateLocal('common.currentDate');.
  https://github.com/Expensify/App/blob/dc74ee347bf3dc134b5488d2a28911cd031104b3/src/libs/WorkspaceReportFieldUtils.ts#L82-L84|
• We can also change the desctiption value to description={!isDateFieldType ? translate('common.initialValue') : translate('common.date')}
  

  App/src/pages/workspace/reportFields/ReportFieldsSettingsPage.tsx

  Line 116 in 06a59ad

  description={translate('common.initialValue')}

Result

[VictoriaExpensify]

I'll be the BZ for this issue so I'll unassign @twisterdotcom

[melvin-bot]

Upwork job price has been updated to $125

[VictoriaExpensify]

This should be a very simple fix, so I'm reducing the bounty on this one

[Krishna2323]

Proposal Updated

• Added alternative (optional) solution.

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-09-25 00:10:10 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Date" options for Report Fields are ambiguous and should be updated

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

Instead of using translate('common.currentDate') we should use the initial value here

App/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx

Line 172 in a7a0c53

title={translate('common.currentDate')}

We can do something like this

             title={inputValues?.initialValue}

Optional: We can remove this code block

App/src/libs/WorkspaceReportFieldUtils.ts

Lines 82 to 84 in 06a59ad

	if (reportField.type === CONST.REPORT_FIELD_TYPES.DATE) {
	return Localize.translateLocal('common.currentDate');
	}

We might also need to do some cleanup

What alternative solutions did you explore? (Optional)

We can also fallback here to translate('common.currentDate')

             title={inputValues?.initialValue ?? translate('common.currentDate') }

[github-actions]

Chris Your proposal will be dismissed because you did not follow the proposal template.

[Krishna2323]

Proposal Updated

• Added alternative 2

[Gajendra-Gupta]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Date" options for Report Fields are ambiguous and should be updated

What is the root cause of that problem?

New Feature request

What changes do you think we should make in order to solve the problem?

we need to change the description value to description={!isDateFieldType ? translate('common.initialValue') : translate('common.date')}.

App/src/pages/workspace/reportFields/ReportFieldsSettingsPage.tsx

Line 116 in 06a59ad

description={translate('common.initialValue')}

What alternative solutions did you explore? (Optional)

[melvin-bot]

@rushatgabhane, @VictoriaExpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@rushatgabhane, @VictoriaExpensify Still overdue 6 days?! Let's take care of this!

[VictoriaExpensify]

@rushatgabhane can you please review these proposals and recommend one?

[VictoriaExpensify]

@rushatgabhane can you please review these proposals and recommend one?

[VictoriaExpensify]

Not overdue

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@rushatgabhane @VictoriaExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[rushatgabhane]

@Krishna2323's proposal LGTM

[rushatgabhane]

🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[VictoriaExpensify]

Thanks @rushatgabhane

@Krishna2323 - let's move forward with your proposal

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

Will raise the PR today.

[Julesssss]

PR will be raised soon

[melvin-bot]

@Julesssss, @rushatgabhane, @VictoriaExpensify, @Krishna2323 Eep! 4 days overdue now. Issues have feelings too...

[Krishna2323]

@VictoriaExpensify @Julesssss, should we also change the current date value to Initial value in the Initial value field when the report field is created? It won't make sense to show Initial value as value in the Initial value field.

Or we can change the desctiption value to description={!isDateFieldType ? translate('common.initialValue') : translate('common.date')}.

We can change the field description from initial value to date and show current date as value. Please let me know WDYT.

Monosnap.screencast.2024-10-16.00-03-06.mp4

[Julesssss]

We can change the field description from initial value to date and show current date as value. Please let me know WDYT.

That seems good to me. Any thoughts @VictoriaExpensify?

[Krishna2323]

@VictoriaExpensify, friendly bump.

[Krishna2323]

We can change the field description from initial value to date and show current date as value. Please let me know WDYT.

That seems good to me. Any thoughts @VictoriaExpensify?

@VictoriaExpensify bump ^