[HOLD for payment 2024-11-13] [HOLD for payment 2024-11-11] [Workspace Feeds] Handle manual bank account verification before provisioning cards

[mountiny]

### Problem

In some cases, when policy admin is adding a VBBA, the bank account cannot be auto-approved, and we need to do manual checks to verify the bank account can be used for reimbursements and expensive cards. If that is the case, we need to make sure the user is not able to start issuing cards and they are aware a manual checks are happening. They receive a concierge message, which is easy to miss as currently they can just freely enter the Issue new card flow.

### Solution

When the VBBA account is added but is added to the waitlist for manual verification, let the user know in the Expensify cards modal that the card is still being manually verified and Concierge will notify them about the successful verification or if they need to provide any more details.

At the same time, disable the issue new card button, as until the bank account is verified, we cannot create new cards.

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Current assignee @dubielzyk-expensify is eligible for the Design assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @sonialiap (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Current assignee @dubielzyk-expensify is eligible for the NewFeature assigner, not assigning anyone new.

[mountiny]

@dubielzyk-expensify Can you please help mock how we should show this on the empty expensify cards page? Also just for completeness how the New card button should look disabled.

[trjExpensify]

Discussing here for the breadcrumbs.

[dubielzyk-expensify]

So shall we go for this then?

[trjExpensify]

Yep! Asking the team who wants it.

[koko57]

I can help with this one 🙂

[trjExpensify]

Thanks! ❤️

[koko57]

For what bankAccount property should I look for to display the text and the buttons conditionally?

cc @sonialiap @mountiny

[koko57]

ok, UI is done, I drafted the PR, now I'm waiting for confirmation on this condition to display the buttons and the text. Also I'm asking for approving Spanish translation

[mountiny]

Commented in the PR

[koko57]

@mountiny I followed the steps you shared to get account in VERIFIED state, but I don't have this account in bankAccountList so I'm still having Continue Modal displayed and "Finish Setup" as the button text
bc of this line const isSetupUnfinished = isEmptyObject(bankAccountList) && reimbursementAccountStatus && reimbursementAccountStatus !== CONST.BANK_ACCOUNT.STATE.OPEN;

[koko57]

So I guess I need to figure out another condition

[mountiny]

@koko57 ok, so you have the private_expensifyCardSettings NVP locally, and it only has the paymentAccountID linked, but that bank account is not in Onyx? Or what is the state of the Onyx variables after you added the bank account?

It seems like it's not exactly the same thing as what @ishpaul777 ran into as they had the card "provisioned" after adding the bank account

[koko57]

ok, we can do it here - but I'm ooo till Monday, so will take care of it then 🙂

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bank account verification modal info #49536

If no regressions arise, payment will be issued on 2024-11-11. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] Fix UI issue for Empty states for Company cards #51780

If no regressions arise, payment will be issued on 2024-11-13. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  https://github.com/Expensify/Expensify/issues/444091

[DylanDylann]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: New Feature
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to a workspace, enable Expensify Card in More Features
2. Go to Expensify Card, click Issue New Card, add a new bank account if you don't have any
3. Choose the bank account from the list
4. After successful verification you should the Empty State screen
5. Repeat steps 1-3, choose the same bank account as in the previous workspace
6. You should see the Empty State screen with the title "Verification in progress..." and the description "We're verifying a few details. Concierge will let you know when Expensify Cards are ready to issue." And the buttons "Issue Card" and "Settings" should not be displayed.

Do we agree 👍 or 👎

[mountiny]

@DylanDylann @koko57 I dont think that test covers exactly what we need. We should check for the different copy on the modal for the second time

[DylanDylann]

@mountiny Thanks. I updated

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @koko57 is from an agency-contributor and not due payment
• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@sonialiap)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[mountiny]

$250 to @DylanDylann

[sonialiap]

Payment summary:

• @DylanDylann $250 - offer sent

https://www.upwork.com/ab/applicants/1857030956887168073/hired

[DylanDylann]

@sonialiap Accepted, TY!

[sonialiap]

Paid 🎉