[$250] Hold - Scanning expense can be approved as 0.00 amount and can not be edited

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.29-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4919126&group_by=cases:section_id&group_order=asc&group_id=309128
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

1. Login as the owner of the workspace> Create a workspace
2. Invite the approver and employee
   3.Navigate to more features> Enable "workflows"
3. On the "Workflow" editor - enable "Add Approvals"
4. Set the Approver account as the Approver

Steps:

1. As employee, submit one manual and one scan expense to workspace chat
2. As approver, hold the manual expense while other expense is still in scanning process
3. As approver, partially approve the expense

Expected Result:

Approver should not be able to approve scanning expense

Actual Result:

Scanning expense can be approved as 0.00 amount and can not be edited when scanning complete and "Enter an amount" and "Enter an merchant" message appears

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6592611_1725437048240.Recording__3869.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831749951127189835
• Upwork Job ID: 1831749951127189835
• Last Price Increase: 2024-09-19

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021831749951127189835

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

@eVoloshchak, @lschurr Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@eVoloshchak, @lschurr Still overdue 6 days?! Let's take care of this!

[eVoloshchak]

Not overdue, this is awaiting proposals

[M00rish]

Edited by proposal-police: This proposal was edited at 2024-09-17 11:50:43 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Scanning expense can be approved as 0.00 amount and can not be edited

What is the root cause of that problem?

App/src/components/ReportActionItem/ReportPreview.tsx

Line 319 in 2190f62

const shouldShowApproveButton = useMemo(() => IOU.canApproveIOU(iouReport, policy), [iouReport, policy]);

for the approval button we do not check if the unheldamount is not 0, so we don't approve it.

App/src/components/ReportActionItem/ReportPreview.tsx

Line 339 in 2190f62

const shouldShowScanningSubtitle = numberOfScanningReceipts === 1 && numberOfRequests === 1;

if there are several money requests this check is going to return false, like in our case here, (there are two transactions so numberOfRequests is 2 ) and so the scanning subtitle is not shown.

What changes do you think we should make in order to solve the problem?

for the approval button we need to check also if the unheld total is not 0:
const shouldShowApproveButton = useMemo(() => IOU.canApproveIOU(iouReport, policy) && Number(nonHeldAmount) !== 0, [iouReport, policy, nonHeldAmount] );

for the scanning subtitle we need to check as well if there's a scan still being done and unheldamount is 0 :

const shouldShowScanningSubtitle = (numberOfScanningReceipts === 1 && numberOfRequests === 1) || (numberOfScanningReceipts >= 1 && Number(nonHeldAmount) === 0);

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

📣 @M00rish! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[lschurr]

@eVoloshchak could you check out this latest proposal?

[M00rish]

Proposal is Updated

[melvin-bot]

@eVoloshchak, @lschurr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@eVoloshchak, @lschurr Eep! 4 days overdue now. Issues have feelings too...

[lschurr]

@eVoloshchak can you look at the updated proposal?

[eVoloshchak]

@M00rish's proposal looks good to me!

🎀👀🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[grgia]

assigning @M00rish!

Could you move the proposed logic pertaining to showing the approval button into canApproveIOU instead of &&

[melvin-bot]

The BZ member will need to manually hire M00rish for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[M00rish]

Sure will do, I will raise a PR for review by tomorrow.

thanks!

[grgia]

@M00rish do you have an update on this?

[M00rish]

I am working on it and wil update asap

[melvin-bot]

@eVoloshchak, @lschurr, @grgia, @M00rish Huh... This is 4 days overdue. Who can take care of this?

[M00rish]

I encountered some issue with ios app will continue testing tomorrow

[melvin-bot]

@eVoloshchak, @lschurr, @grgia, @M00rish 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[M00rish]

I tested on the ios platform, scaleway restricted my account and I am figuring it out with their support to test on Android as well, I apologize for the delay

[M00rish]

PR is ready for review,

cc: @eVoloshchak @grgia

[ikevin127]

@eVoloshchak @grgia I'm here to ask what was the logic behind the fix here, was it to not allow Approve while a scan expense is still scanning OR is it to not allow approval if the transaction amount is 0 ?

The expected result states:

Approver should not be able to approve scanning expense

• Asking because in issue [$250] Hybrid iOS app –IOU –Approval button is missing after payment of the report with hold expense #50932 I proposed to change the canApproveIOU implementation of unheldTotalIsZero added by the PR from this issue to not allow Approve while a scan expense is still scanning, but this will still allow approval once the scanning is finished if the user doesn't do anything about the errors, like adding an amount - the transaction can still be approved with amount 0 for example.
• More details about my proposed change / fix can be found here in my proposal: [$250] Hybrid iOS app –IOU –Approval button is missing after payment of the report with hold expense #50932 (comment)

Wdyt ?