-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD #42118][$250] Expense status doesn't update after completing the action #46914
Comments
Triggered auto assignment to @slafortune ( |
Job added to Upwork: https://www.upwork.com/jobs/~01bfe746236df54daa |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah ( |
Edited by proposal-police: This proposal was edited at 2023-10-04 10:15:00. ProposalPlease re-state the problem that we are trying to solve in this issue.The message "Waiting for Sara Couto to fix the issue(s)" was still there even after fixing the violation What is the root cause of that problem?When we approve/submit money request, we'll generate the Line 6822 in 2200fd7
Line 7066 in 2200fd7
However, when editing amount Line 5415 in 2200fd7
What changes do you think we should make in order to solve the problem?To fix it holistically for all money request update operations,
What alternative solutions did you explore? (Optional)We should at some point handle the case where "There's no violation before, but after edit there's violation", in that case the next step will be "Wait for {user} to fix the issue(s)". I think this is out of scope of this issue for now. |
Proposal updated to add notes in the alternative section |
@dominictb - I think we should keep the "Wait for {user} to fix the issue(s)" next step message if we have optimistic violations returned from here: Line 5439 in 2200fd7
Lines 2691 to 2701 in 2200fd7
We should change the next step message only if there are current transaction violations and there are no optimistic transaction violations. we need also to restore the next step in case of failure. Could you please update your proposal and ping me again once it's ready for another review? |
@rayane-djouah Hey sure that's what I meant by below point in my proposal, let me update with a bit more details in the proposal
|
Moving to #wave-control as it's optimistic next steps/violations related. CC: @dangrous @dylanexpensify |
assigning myself so I can take a look when proposals are approved! |
@dominictb your proposal RCA and solution makes sense to me. However, to fix the bug for all money request update flows, we need to make the changes in Could you please add a sample code that describes which changes should we make in |
Will provide an update early tomorrow. |
TY! |
Adding another BZ - I'll be out until 8/21 |
Triggered auto assignment to @mallenexpensify ( |
#46914 (comment) proposal updated! |
@dominictb's proposal looks good to me 🎀👀🎀 C+ reviewed |
Current assignee @dangrous is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Yep, looks good to me! I'm wondering - to solve the "There's no violation before, but after edit there's violation" case, could we just do: |
📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Nice, @dominictb when can we get the PR raised for review? |
The PR will be ready by tmr. |
Okay so in talking with @mountiny and trying to make this work on the backend, it's going to bog down our code speed and also just be very tricky to do it currently. However! We're in the process of migrating the next steps code, and once that's done we should be able to fix this much more easily. It does mean in the meantime, though, that we won't want to merge this front-end fix if it will just be overwritten by the backend. So I think this (and the PR, which I'll post on too) will be on hold for the next steps migration to auth. Sorry for the trouble! |
This issue has not been updated in over 15 days. @dangrous, @slafortune, @rayane-djouah, @dominictb eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Still on hold Melvin, don't close this. |
Hold on #42118 |
We've actually got a temporary backend fix that should get this moving again, should be merged soon. We're still doing the migration, but I'm pretty sure this will work in the meantime. |
Great! Please let us know once it's deployed |
Okay I thinkkkkk this is deployed. Can we retest and see if it's fixed? |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.17-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @saracouto
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722617920576379
Action Performed:
Expected Result:
Once the user clears the violation, the message should update from "Waiting for Sara Couto to fix the issue(s)" to the corresponding next step
Actual Result:
The message "Waiting for Sara Couto to fix the issue(s)" was still there even after fixing the violation
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Recording.419.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @rayane-djouahThe text was updated successfully, but these errors were encountered: