Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Imported reports become "Hmm... it's not here" in new dot #46576

Open
1 of 6 tasks
m-natarajan opened this issue Jul 31, 2024 · 64 comments
Open
1 of 6 tasks

[$250] Imported reports become "Hmm... it's not here" in new dot #46576

m-natarajan opened this issue Jul 31, 2024 · 64 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors Internal Requires API changes or must be handled by Expensify staff

Comments

@m-natarajan
Copy link

m-natarajan commented Jul 31, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.14-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @hannojg
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722248571855789

Action Performed:

  1. Imported reports in old dot (the attached file, 500 reports)
  2. The reports show up in the workspace chat in new dot after import
  3. clicking on a report in new dot gets you the "Hmm... it's not here" error

Expected Result:

Imported reports are usable in new dot

Actual Result:

Clicking on a report in new dot gets you the "Hmm... it's not here" error

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-07-29.at.12.19.55.mov

View all open jobs on GitHub

Recording.397.mp4
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cad85d32f0e40e56
  • Upwork Job ID: 1822053156621252764
  • Last Price Increase: 2024-09-06
Issue OwnerCurrent Issue Owner: @hoangzinh
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 31, 2024
Copy link

melvin-bot bot commented Jul 31, 2024

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Aug 5, 2024

@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Aug 7, 2024

@kevinksullivan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Aug 9, 2024

@kevinksullivan 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@kevinksullivan kevinksullivan added the External Added to denote the issue can be worked on by a contributor label Aug 9, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01cad85d32f0e40e56

@melvin-bot melvin-bot bot changed the title Imported reports become "Hmm... it's not here" in new dot [$250] Imported reports become "Hmm... it's not here" in new dot Aug 9, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 9, 2024
Copy link

melvin-bot bot commented Aug 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

@melvin-bot melvin-bot bot removed the Overdue label Aug 9, 2024
@kevinksullivan
Copy link
Contributor

I think this is a low priority Control item, because it's covering a backwards compatibility edge case

Copy link

melvin-bot bot commented Aug 10, 2024

📣 @sandeepvasudewan! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@sandeepvasudewan
Copy link

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: [email protected]

Copy link

melvin-bot bot commented Aug 10, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@hoangzinh
Copy link
Contributor

Hi @sandeepvasudewan can you update your proposal with the PROPOSAL_TEMPLATE here?

@sandeepvasudewan
Copy link

sandeepvasudewan commented Aug 11, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

The problem we are addressing is that when reports are imported from the old dot to the new dot, they initially appear in the workspace chat. However, when users click on these reports, they encounter an error message: "Hmm... it's not here," rendering the reports inaccessible.

What is the root cause of that problem?

The root cause of the problem likely stems from discrepancies between the report identifiers, URLs, or metadata used in the old dot versus those expected in the new dot. This mismatch causes the new dot system to fail in correctly locating or displaying the imported reports, leading to the error message.

What changes do you think we should make in order to solve the problem?

To solve this issue, we should implement the following changes:

  1. Normalize Report IDs/URLs: During the import process, ensure that report IDs/URLs are converted to match the format expected by the new dot system. This normalization process will involve mapping old dot identifiers to their corresponding new dot formats.
  2. Enhance Routing Logic: Update the routing logic in the new dot to handle these normalized IDs/URLs properly. This may include adding backward compatibility to ensure that reports are correctly routed and displayed.
  3. Introduce a Fallback Mechanism: Implement a fallback mechanism that attempts to locate reports using alternative identifiers or metadata in cases where the initial lookup fails.

What alternative solutions did you explore? (Optional)

Alternative solutions considered include:

  • Rewriting the Import Logic: Completely rewriting the import logic to align the old dot's data structure with the new dot's format. This approach was deemed too complex and resource-intensive.
  • Manual Mapping During Import: Manually mapping each report from the old dot to the new dot during the import process. However, this method was found to be less scalable and prone to errors, especially in large-scale operations.

@hoangzinh
Copy link
Contributor

@sandeepvasudewan you don't need to delete and then create a new comment/proposal. Just update the existing one and leave a comment update (Ref: https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#propose-a-solution-for-the-job)

Btw,

The root cause of the problem likely stems from discrepancies between the report identifiers, URLs, or metadata used in the old dot versus those expected in the new dot

Can you give describe exactly what are differents between the report identifiers, URLs, or metadata used in the old dot versus those expected in the new dot?

This mismatch causes the new dot system to fail in correctly locating or displaying the imported reports

Then, can you reference to which line of code in New Dot that locates imported reports as you mentioned above? Thank you

Copy link

melvin-bot bot commented Aug 14, 2024

@hoangzinh @kevinksullivan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@hoangzinh
Copy link
Contributor

Still waiting proposals

Copy link

melvin-bot bot commented Aug 16, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@hoangzinh
Copy link
Contributor

Same as above

Copy link

melvin-bot bot commented Aug 22, 2024

@hoangzinh, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Aug 22, 2024
@hoangzinh
Copy link
Contributor

Still waiting proposals

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2024
Copy link

melvin-bot bot commented Sep 30, 2024

@hoangzinh, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 30, 2024
@hoangzinh
Copy link
Contributor

same as above

@melvin-bot melvin-bot bot removed the Overdue label Oct 1, 2024
Copy link

melvin-bot bot commented Oct 4, 2024

@hoangzinh, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Oct 4, 2024
@hoangzinh
Copy link
Contributor

still waiting for internal

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2024
@hoangzinh
Copy link
Contributor

@zanyrenney if this issue is not a high priority, can we put it weekly?

Copy link

melvin-bot bot commented Oct 8, 2024

@hoangzinh, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 8, 2024
@hoangzinh
Copy link
Contributor

same as above.

@melvin-bot melvin-bot bot removed the Overdue label Oct 8, 2024
Copy link

melvin-bot bot commented Oct 14, 2024

@hoangzinh, @zanyrenney Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Oct 14, 2024
@hoangzinh
Copy link
Contributor

@zanyrenney do you have any update from the internal team?

@melvin-bot melvin-bot bot removed the Overdue label Oct 15, 2024
Copy link

melvin-bot bot commented Oct 18, 2024

@hoangzinh, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 18, 2024
@hoangzinh
Copy link
Contributor

Awaiting @zanyrenney here #46576 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Oct 21, 2024
@zanyrenney
Copy link
Contributor

hey @hoangzinh thanks for the ping.

@zanyrenney
Copy link
Contributor

Seems like noone internal has been able to pick this up. Can we confirm the behaviour is still reproducible on the latest build?

@zanyrenney
Copy link
Contributor

If so, I can re-flag this in the #expense room

@hoangzinh
Copy link
Contributor

yes, I can still reproduce this bug

Copy link

melvin-bot bot commented Oct 25, 2024

@hoangzinh, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2024
@hoangzinh
Copy link
Contributor

Waiting @zanyrenney grab an internal engineer for us

@melvin-bot melvin-bot bot removed the Overdue label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors Internal Requires API changes or must be handled by Expensify staff
Projects
Status: Polish
Development

No branches or pull requests

9 participants