Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] Thread – Reply is present when create a second level thread and delete comment #41399

Closed
3 of 6 tasks
izarutskaya opened this issue May 1, 2024 · 52 comments
Closed
3 of 6 tasks

[$250] Thread – Reply is present when create a second level thread and delete comment #41399

izarutskaya opened this issue May 1, 2024 · 52 comments
Assignees
@garrettmknight
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented May 1, 2024 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: v1.4.69-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4530392
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in.
  3. Go to any chat and send a message.
  4. Create a thread and send a comment.
  5. Create a second level thread and don’t send messages
  6. Go back and delete the comment from step 4
  7. Observe that there are no comments in the thread
  8. Go back to parent chat

Expected Result:

There is no reply under the message when create a second level thread and delete comment

Actual Result:

Reply is present under the message when create a second level thread and delete comment

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6467602_1714552068810.Threas_2_lev.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011780584d68800980
  • Upwork Job ID: 1785737118212800512
  • Last Price Increase: 2024-05-08
@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 1, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 1, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@izarutskaya
Copy link
Author

We think this issue might be related to the #vip-vsb.

@cretadn22
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

The count message within the thread becomes inaccurate when a comment is deleted.

What is the root cause of that problem?

Even after deleting the last comment, the DeleteComment API continues to return childVisibleActionCount is 1, which is used to display the count message in the child thread.

What changes do you think we should make in order to solve the problem?

We need to address this issue from the backend. How can I gain access to the backend codebase?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@dragnoir
Copy link
Contributor

dragnoir commented May 1, 2024

BE issue, wrong "childCommenterCount" value

@garrettmknight garrettmknight added the External Added to denote the issue can be worked on by a contributor label May 1, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 1, 2024

Job added to Upwork: https://www.upwork.com/jobs/~011780584d68800980

@melvin-bot melvin-bot bot changed the title Thread – Reply is present when create a second level thread and delete comment [$250] Thread – Reply is present when create a second level thread and delete comment May 1, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 1, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 1, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

@ikevin127
Copy link
Contributor

This looks BE related based on findings from proposal and #41399 (comment) -> therefore I think it should be fixed internally.

@melvin-bot melvin-bot bot added the Overdue label May 6, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 7, 2024

@garrettmknight, @ikevin127 Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 8, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 9, 2024

@garrettmknight, @ikevin127 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@garrettmknight
Copy link
Contributor

Thanks @ikevin127 - moving to Internal.

@melvin-bot melvin-bot bot removed the Overdue label May 9, 2024
@garrettmknight garrettmknight added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels May 9, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 9, 2024

Current assignee @ikevin127 is eligible for the Internal assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
@garrettmknight
Copy link
Contributor

Waiting for volunteer.

@melvin-bot melvin-bot bot removed the Overdue label May 13, 2024
@atef1995 atef1995 mentioned this issue May 14, 2024
Open
@melvin-bot melvin-bot bot added the Overdue label May 15, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 15, 2024

@garrettmknight @ikevin127 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@garrettmknight garrettmknight removed the Daily KSv2 label Jul 12, 2024
@garrettmknight
Copy link
Contributor

Still looking for a volunteer!

@melvin-bot melvin-bot bot added the Overdue label Jul 25, 2024
@ikevin127
Copy link
Contributor

Looking for a volunteer 🎲

@melvin-bot melvin-bot bot removed the Overdue label Jul 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 2, 2024
@ikevin127
Copy link
Contributor

Looking for a volunteer 🎲

@melvin-bot melvin-bot bot removed the Overdue label Aug 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 12, 2024
@garrettmknight
Copy link
Contributor

Still waiting for a volunteer.

@melvin-bot melvin-bot bot removed the Overdue label Aug 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2024
@garrettmknight
Copy link
Contributor

Still waiting for a volunteer.

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 30, 2024
@garrettmknight
Copy link
Contributor

Still waiting for a volunteer.

@melvin-bot melvin-bot bot removed the Overdue label Sep 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 10, 2024
@garrettmknight
Copy link
Contributor

Still waiting for a volunteer.

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 20, 2024
@garrettmknight
Copy link
Contributor

Still waiting for a volunteer.

@melvin-bot melvin-bot bot removed the Overdue label Sep 23, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 1, 2024
@garrettmknight
Copy link
Contributor

Still waiting for a volunteer.

@melvin-bot melvin-bot bot removed the Overdue label Oct 2, 2024
@garrettmknight
Copy link
Contributor

Still waiting for a volunteer.

@garrettmknight
Copy link
Contributor

Closing since VSB is closed, will wait on real reporting to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garrettmknight garrettmknight

Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
[#whatsnext] #vip-vsb
Status: HIGH
Milestone
No milestone
Development

No branches or pull requests
5 participants
@garrettmknight @dragnoir @ikevin127 @izarutskaya @cretadn22