[HOLD for payment 2024-04-05] [$250] [Simplified Collect][Distance rates] - Back icon not functioning and close to status bar on rate edit screen

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.56.0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #38237
Issue reported by: Applause - Internal team

Action Performed:

Precondition: user created a collect policy in OD

1. Open the app and log in as the admin of the collect policy
2. Navigate to the workspace settings > More features
3. Enable Distance rates
4. Open Distance rates
5. Select any distance rate
6. Tap the rate value
7. Tap the back icon

Expected Result:

The back icon is functioning, user can return to the previous screen

Actual Result:

The back icon is too close to the status bar and is not functioning

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423960_1711160389870.video_2024-03-22_22-11-05.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018bf3c7d04bca8505
• Upwork Job ID: 1772188385248808960
• Last Price Increase: 2024-03-25

Issue Owner

Current Issue Owner: @anmurali

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Triggered auto assignment to @grgia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Back icon not functioning and close to status bar on rate edit screen

What is the root cause of that problem?

We do not pass shouldEnableMaxHeight:

App/src/pages/workspace/distanceRates/PolicyDistanceRateEditPage.tsx

Lines 66 to 71 in 2003844

	<ScreenWrapper
	style={[styles.pb0]}
	includePaddingTop={false}
	includeSafeAreaPaddingBottom={false}
	testID={PolicyDistanceRateEditPage.displayName}
	>

What changes do you think we should make in order to solve the problem?

Pass shouldEnableMaxHeight & also update style to: style={[styles.defaultModalContainer]}

 <ScreenWrapper 
     style={[styles.defaultModalContainer]}
     includePaddingTop={false} 
     includeSafeAreaPaddingBottom={false} 
     testID={PolicyDistanceRateEditPage.displayName} 
     shouldEnableMaxHeight
 > 

We already do that in edit tag and edit category page:

App/src/pages/workspace/tags/EditTagPage.tsx

Lines 74 to 79 in 2003844

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	style={[styles.defaultModalContainer]}
	testID={EditTagPage.displayName}
	shouldEnableMaxHeight
	>

App/src/pages/workspace/categories/EditCategoryPage.tsx

Lines 49 to 54 in 2003844

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	style={[styles.defaultModalContainer]}
	testID={EditCategoryPage.displayName}
	shouldEnableMaxHeight
	>

What alternative solutions did you explore? (Optional)

N/A

[MrMuzyk]

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018bf3c7d04bca8505

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[melvin-bot]

Upwork job price has been updated to $250

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: change props for edit rate page wrapper #38932

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @MrMuzyk does not require payment (Contractor)
• @eh2077 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eh2077] The PR that introduced the bug has been identified. Link to the PR:
• [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eh2077] Determine if we should create a regression test for this bug.
• [@eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

Thanks! this will be $250 to @eh2077

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @MrMuzyk is from an agency-contributor and not due payment
• ROLE: @eh2077 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@anmurali)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1772188385248808960/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[luacmartins]

Just pending payment @anmurali

[mountiny]

Summary here

[melvin-bot]

@anmurali, @luacmartins, @MrMuzyk, @mountiny, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

Waiting on payment

[luacmartins]

Still pending payment

[melvin-bot]

@anmurali, @luacmartins, @MrMuzyk, @mountiny, @eh2077 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[anmurali]

Offer sent to @eh2077 - https://www.upwork.com/nx/wm/offer/101898363

[eh2077]

@anmurali Accepted offer, thank you.

[melvin-bot]

@anmurali, @luacmartins, @MrMuzyk, @mountiny, @eh2077 Huh... This is 4 days overdue. Who can take care of this?

[luacmartins]

@anmurali @eh2077 are we good to close this one?

[eh2077]

@anmurali @eh2077 are we good to close this one?

Ah, still waiting for the payment.

[anmurali]

Paid.