-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$100] Group chat - No tooltip when hovering over group member avatar in details page #29322
Comments
Triggered auto assignment to @NicMendonca ( |
Bug0 Triage Checklist (Main S/O)
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @joelbettner ( |
I am available right now and can raise quick PR if needed ProposalPlease re-state the problem that we are trying to solve in this issue.Tooltip is not working in group details page avatars What is the root cause of that problem?In App/src/components/RoomHeaderAvatars.js Lines 90 to 98 in 907e65e
What changes do you think we should make in order to solve the problem?We should wrap avatar components in <UserDetailsTooltip
key={`stackedAvatars-${index}`}
accountID={icon.id}
icon={icon}
fallbackUserDetails={{
displayName: icon.name,
avatar: icon.avatar,
}}
>
<View>
<Avatar
source={icon.source}
fill={themeColors.iconSuccessFill}
size={CONST.AVATAR_SIZE.LARGE}
containerStyles={[...iconStyle, StyleUtils.getAvatarBorderRadius(CONST.AVATAR_SIZE.LARGE_BORDERED, icon.type)]}
name={icon.name}
type={icon.type}
fallbackIcon={icon.fallbackIcon}
/></View>
</UserDetailsTooltip> What alternative solutions did you explore? (Optional) |
This begs the question...do we want to show the tool tip on the "RoomHeaderAvatars" as per @alitoshmatov 's proposal? |
We added this change as part of this wave 8 issue: #27394 so I will tag @MitchExpensify @trjExpensify @shawnborton to confirm if we want to show the tooltip or not, but I agree that it shouldn't be a deploy blocker. |
Cool cool. Given that it is also not a bug, I'm going to un-assign myself while that discussion happens. |
I think we want to show the tooltip as we do everywhere for consistency but I agree this is not a blocker, we could export this for $250 |
Job added to Upwork: https://www.upwork.com/jobs/~01939a661b5c2c58a4 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 ( |
Upwork job price has been updated to $100 |
Huh? What's the issue here? We don't show a tooltip when you hover over a user avatar in the profile page, why do we need to do it here in the group details page? A tooltip on hover over the name is enough IMO. |
I am going to close this because this is expected behaviour. Please re-open the issue or bring a discussion in Slack if you disagree. |
Alright, we used to show the tooltip almost everywhere so if these are the exception, thats fine |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.3.81-4
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Tooltip appears when hovering over group member avatar
Actual Result:
Tooltip does not appear when hovering over group member avatar
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6233110_1697032667398.20231011_201711.mp4
MacOS: Desktop
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: