[HOLD for payment 2023-10-13] [HOLD for payment 2023-10-12] [$500] Dev: Web - Hmm it's not there message appears if open private notes in offline mode #27591

kbecciv · 2023-09-16T18:32:11Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Create workspace
Go offline
Go to #admins
Click on header
Go to Private notes

Expected Result:

It should show private notes

Actual Result:

hmm it's not there message appear

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: Dev 1.3.70.5
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-15.at.6.55.49.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694784369659399

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0114cd1c2b0e08bcd2
Upwork Job ID: 1703114589030166528
Last Price Increase: 2023-09-16
Automatic offers:

ahmedGaber93 | Contributor | 26937500
gadhiyamanan | Reporter | 26937502
tienifr | Contributor | 26938659

ahmedGaber93 · 2023-09-16T18:32:12Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

hmm it's not there message appears if open private notes in offline mode

What is the root cause of that problem?

the FullPageNotFoundView shouldShow has (!report.isLoadingPrivateNotes && network.isOffline && _.isEmpty(lodashGet(report, 'privateNotes', {}))) which make it true when offline and page not loaded before

App/src/pages/PrivateNotes/PrivateNotesListPage.js

Line 122 in 76c1559

    
           shouldShow={_.isEmpty(report.reportID) || (!report.isLoadingPrivateNotes && network.isOffline && _.isEmpty(lodashGet(report, 'privateNotes', {})))}

What changes do you think we should make in order to solve the problem?

In this case, We can show offline view instead of not fount

const isOfflineAndEmpty = !report.isLoadingPrivateNotes && network.isOffline && _.isEmpty(lodashGet(report, 'privateNotes', {}));


<FullPageNotFoundView
    shouldShow={_.isEmpty(report.reportID) || isOfflineAndEmpty}
    icon={isOfflineAndEmpty ? Expensicons.OfflineCloud : undefined}
    titleKey={isOfflineAndEmpty ? "common.youAppearToBeOffline" : undefined}
    subtitleKey={isOfflineAndEmpty ? "common.thisFeatureRequiresInternet" : undefined}
    onBackButtonPress={() => Navigation.goBack()}
>

we need to add prop icon to FullPageNotFoundView to control it by prop

also we can remove subtitle or use other subtitle words

What alternative solutions did you explore? (Optional)

we can instead remove network.isOffline && and keep page in loading

melvin-bot · 2023-09-16T18:32:16Z

Job added to Upwork: https://www.upwork.com/jobs/~0114cd1c2b0e08bcd2

melvin-bot · 2023-09-16T18:32:20Z

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

melvin-bot · 2023-09-16T18:32:26Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

narefyev91 · 2023-09-18T07:51:37Z

After clarification Proposal from @tienifr looks good to me #27591 (comment)
🎀 👀 🎀 C+ reviewed

melvin-bot · 2023-09-18T07:51:46Z

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

tienifr · 2023-09-18T08:37:32Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev: Web - Hmm it's not there message appears if open private notes in offline mode

What is the root cause of that problem?

After creating the WS, we don't fetch the private note data. So when users go offline and visit private note page, we don't allow the API call -> it's empty and isLoadingPrivateNotes is false -> we show the not found page

App/src/pages/PrivateNotes/PrivateNotesListPage.js

Lines 64 to 69 in 4d97719

    
           useEffect(() => { 
        
               if (network.isOffline) { 
        
                   return; 
        
               } 
        
               Report.getReportPrivateNote(report.reportID); 
        
           }, [report.reportID, network.isOffline]);

What changes do you think we should make in order to solve the problem?

We should not prevent API call when network is offline as what we did with other read APIs. When users go to privateNote page, isLoadingPrivateNotes should be true no matter the network is

change this line

App/src/pages/PrivateNotes/PrivateNotesListPage.js

Line 65 in 4d97719

if (network.isOffline) {

to

        if(network.isOffline && report.isLoadingPrivateNotes){

tienifr · 2023-09-18T08:40:26Z

@narefyev91 Sorry for the delay proposal. I see other places that use API.read(), we should not prevent API call when users go offline (that cause this bug). So for consistency, we should add other condition report.isLoadingPrivateNotes to prevent API call here. What do you think

narefyev91 · 2023-09-18T08:50:51Z

@tienifr based on your changes - what user will see - loading screen?

tienifr · 2023-09-18T08:52:57Z

Yes, I think it's better than offline view. Here's the demo @narefyev91

Screen.Recording.2023-09-18.at.15.51.46.mov

ahmedGaber93 · 2023-09-18T09:22:51Z

I think there is no prevent API call here. because useEffect deps hase network.isOffline and when user back online this dependency will change, and the api will call

App/src/pages/PrivateNotes/PrivateNotesListPage.js

Lines 64 to 69 in 4d97719

    
           useEffect(() => { 
        
               if (network.isOffline) { 
        
                   return; 
        
               } 
        
               Report.getReportPrivateNote(report.reportID); 
        
           }, [report.reportID, network.isOffline]);

tienifr · 2023-09-18T09:25:51Z

we should not prevent API call when users go offline

@ahmedGaber93 I mean when users go offline.

narefyev91 · 2023-09-18T11:59:23Z

Yup i think we need here correct behaviour - in case in expected results we not see a clear picture.
We have 2 cases here - either we show offline screen - with suggestion to go online or we show loaded - until user will not get back to online
First case - proposal from @ahmedGaber93
Second case proposal from @tienifr
We will need your help @grgia

tienifr · 2023-09-20T02:24:42Z

@grgia What do you think about this?

narefyev91 · 2023-09-21T07:02:51Z

Friendly bump - @grgia

grgia · 2023-09-25T08:06:15Z

@narefyev91 could you explain what you mean by "offline screen" with a screenshot

narefyev91 · 2023-09-25T08:21:07Z

@grgia

grgia · 2023-09-25T11:15:37Z

I prefer the offline page pattern @narefyev91, could you remind me which proposal that was?

narefyev91 · 2023-09-25T11:45:29Z

@grgia #27591 (comment) from @ahmedGaber93

tienifr · 2023-09-26T02:34:35Z

@grgia @narefyev91 I don't think the offline page is the good idea. The offline page should be shown for the page that really need the network (bank account). In this page, when we already loaded the data before (it was in Onyx) we can still use this page. Beside, in our App when calling API.read, we just need to update isLoading to false no matter the network is

ahmedGaber93 · 2023-09-26T08:51:29Z

I think it is a normal and expected behavior to displaying offline page when user offline and no onxy data yet

melvin-bot · 2023-10-05T00:07:46Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-10-05T00:07:50Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: Private notes page shows not found in offline mode #28461

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@narefyev91 does not require payment (Contractor)
@tienifr requires payment offer (Contributor)
@gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-06T07:44:41Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: GetReportPrivateNote gets called continuously #28787

If no regressions arise, payment will be issued on 2023-10-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@narefyev91 does not require payment (Contractor)
@tienifr requires payment offer (Contributor)
@gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

kbecciv · 2023-10-12T17:46:17Z

@narefyev91 @NicMendonca
Issue is not fixed on build 1.3.83.1

Recording.4978.mp4

tranvantoan-qn · 2023-10-13T02:44:14Z

This doesn't seem fixed yet (we have missed the self-test and regression test), or there's a similar case as the one I reported here. - https://expensify.slack.com/archives/C049HHMV9SM/p1697131558107909

Furthermore, with this solution, consider the following scenario:

User is in online mode.
User views A's private notes.
User goes offline.
User navigates to somewhere else in the app in offline mode.
User goes back to A's private notes.

Question: Will the private notes still display, or will the offline page display? We need to make sure that the private notes are still showing.

(IMO, showing Skeleton UI can be a better option)

NicMendonca · 2023-10-13T19:01:52Z

@grgia what do you think? ^

grgia · 2023-10-16T13:26:51Z

@tranvantoan-qn

Yes, if the data is loaded, we should show it.

tranvantoan-qn · 2023-10-16T13:38:43Z

@grgia So we need to confirm that the original proposal is already merged and then check the case I mentioned above

grgia · 2023-10-19T12:44:05Z

@narefyev91 could you take a look at the progression of this issue?

narefyev91 · 2023-10-19T12:53:28Z

@tienifr can you please take a look at the latest comments - seems after we get on Private Notes - and after some times spinner is moving away and we still see "Hmmm is not here page"
reference #27591 (comment)

tienifr · 2023-10-19T16:02:20Z

@grgia @narefyev91 After investigating the RCA, I found out that the PR cause the regressions. Before that PR, the failure API will not update the failureData. After it's merged, the failure data of API GetReportPrivateNote update isLoadingPrivateNotes to false -> That causes the problem

App/src/libs/actions/Report.js

Line 2295 in e726c62

isLoadingPrivateNotes: false,

tienifr · 2023-10-19T16:02:39Z

I don't think we should handle this one as the regression

NicMendonca · 2023-10-20T20:19:53Z

reporter: @gadhiyamanan - you've been paid!
contributor: @tienifr - you've been paid!

@tienifr do we need to keep this open for any reason?

grgia · 2023-10-24T11:29:27Z

closing

kbecciv added the External Added to denote the issue can be worked on by a contributor label Sep 16, 2023

melvin-bot bot changed the title ~~Dev: Web - Hmm it's not there message appears if open private notes in offline mode~~ [$500] Dev: Web - Hmm it's not there message appears if open private notes in offline mode Sep 16, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 16, 2023

melvin-bot bot assigned NicMendonca Sep 16, 2023

melvin-bot bot added the Daily KSv2 label Sep 16, 2023

melvin-bot bot assigned narefyev91 Sep 16, 2023

melvin-bot bot assigned grgia Sep 18, 2023

melvin-bot bot added the Overdue label Sep 25, 2023

melvin-bot bot removed the Overdue label Sep 25, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Oct 5, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 6, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 11, 2023

melvin-bot bot added the Overdue label Oct 13, 2023

melvin-bot bot added Overdue and removed Overdue labels Oct 13, 2023

melvin-bot bot removed the Overdue label Oct 16, 2023

melvin-bot bot added the Overdue label Oct 19, 2023

melvin-bot bot removed the Overdue label Oct 19, 2023

melvin-bot bot added the Overdue label Oct 23, 2023

grgia closed this as completed Oct 24, 2023

melvin-bot bot removed the Overdue label Oct 24, 2023

tranvantoan-qn mentioned this issue Oct 25, 2023

[HOLD for payment 2024-01-18] [$500] Private Note - The message 'Hmm... it's not here' displays instead of Skeleton UI when viewing Private Notes in Offline Mode. #30246

Closed

6 tasks

[HOLD for payment 2023-10-13] [HOLD for payment 2023-10-12] [$500] Dev: Web - Hmm it's not there message appears if open private notes in offline mode #27591

[HOLD for payment 2023-10-13] [HOLD for payment 2023-10-12] [$500] Dev: Web - Hmm it's not there message appears if open private notes in offline mode #27591

Comments

kbecciv commented Sep 16, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

ahmedGaber93 commented Sep 16, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Sep 16, 2023

melvin-bot bot commented Sep 16, 2023

melvin-bot bot commented Sep 16, 2023

narefyev91 commented Sep 18, 2023 • edited Loading

melvin-bot bot commented Sep 18, 2023

tienifr commented Sep 18, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

tienifr commented Sep 18, 2023

narefyev91 commented Sep 18, 2023

tienifr commented Sep 18, 2023 • edited Loading

ahmedGaber93 commented Sep 18, 2023

tienifr commented Sep 18, 2023

narefyev91 commented Sep 18, 2023

tienifr commented Sep 20, 2023

narefyev91 commented Sep 21, 2023

grgia commented Sep 25, 2023

narefyev91 commented Sep 25, 2023

grgia commented Sep 25, 2023

narefyev91 commented Sep 25, 2023

tienifr commented Sep 26, 2023

ahmedGaber93 commented Sep 26, 2023 • edited Loading

melvin-bot bot commented Oct 5, 2023

melvin-bot bot commented Oct 5, 2023

melvin-bot bot commented Oct 6, 2023

kbecciv commented Oct 12, 2023 • edited Loading

tranvantoan-qn commented Oct 13, 2023 • edited Loading

NicMendonca commented Oct 13, 2023

grgia commented Oct 16, 2023

tranvantoan-qn commented Oct 16, 2023 • edited Loading

grgia commented Oct 19, 2023

narefyev91 commented Oct 19, 2023 • edited Loading

tienifr commented Oct 19, 2023

tienifr commented Oct 19, 2023

NicMendonca commented Oct 20, 2023

grgia commented Oct 24, 2023

kbecciv commented Sep 16, 2023 •

edited by melvin-bot bot

Loading

narefyev91 commented Sep 18, 2023 •

edited

Loading

tienifr commented Sep 18, 2023 •

edited

Loading

tienifr commented Sep 18, 2023 •

edited

Loading

ahmedGaber93 commented Sep 26, 2023 •

edited

Loading

kbecciv commented Oct 12, 2023 •

edited

Loading

tranvantoan-qn commented Oct 13, 2023 •

edited

Loading

tranvantoan-qn commented Oct 16, 2023 •

edited

Loading

narefyev91 commented Oct 19, 2023 •

edited

Loading