other users can access and replay to Concierge message "Hi there! This is your first time chatting ..." using link

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1- using User A, initiate a new chat with User B.
2-on User B click reply on the concierge message
3- copy the link
4- past the link in user A
5 - send a message

Expected Result:

after pasting the link "Hmm ... it's not here" page should be displayed

Actual Result:

User A is able to send replays to User B Concierge message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.53-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

concierge-bug.1.webm

Recording.5829.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hichamcc
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691277889680489

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

other users can access and replay to Concierge message "Hi there! This is your first time chatting ..." using link

What is the root cause of that problem?

App/src/pages/home/ReportScreen.js

Line 297 in 9348d53

shouldShow={(!this.props.report.reportID && !this.props.report.isLoadingReportActions && !isLoading) || shouldHideReport}

Because we are missing condition for thread with Concierge.

What changes do you think we should make in order to solve the problem?

1. check if thread chat with Concierge
   action.participantAccountIDs contains Concierge ID or action. participants contains [email protected].
2. In this case, check actorAccountID of ReportActionsUtils.getParentReportAction(report) for thread chat with .
   if <1> is true and <2> is null, then we have to set shouldShow of FullPageNotFoundView as true

What alternative solutions did you explore? (Optional)

[NicMendonca]

after pasting the link "Hmm ... it's not here" page should be displayed

Why? I don't think I understand this. Isn't it a link to the chat with the user?

[hichamcc]

after pasting the link "Hmm ... it's not here" page should be displayed

Why? I don't think I understand this. Isn't it a link to the chat with the user?

Link to the reply of the concierge message.

[NicMendonca]

I don't think this is an actually use case a customer will take. closing this for now