-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-08-10] [$1000] Web - Still able to access participants page of archived room - Result in empty page. #23473
Comments
Triggered auto assignment to @sakluger ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Still able to access participants page of archived workspace - Result in empty page. What is the root cause of that problem?We're checking here to show NotFoundPage inside App/src/pages/ReportParticipantsPage.js Line 93 in cd851d0
As we can see, we don't have a check incase the room is archived or empty member. What changes do you think we should make in order to solve the problem?Which should add more condition here for archived room or empty members. <FullPageNotFoundView shouldShow={_.isEmpty(props.report) || ReportUtils.isArchivedRoom(props.report)}> or <FullPageNotFoundView shouldShow={_.isEmpty(props.report) || _.isEmpty(participants)}> or both of above condition: <FullPageNotFoundView shouldShow={_.isEmpty(props.report) || _.isEmpty(participants) || ReportUtils.isArchivedRoom(props.report)}> What alternative solutions did you explore? (Optional)N/A |
Job added to Upwork: https://www.upwork.com/jobs/~01f9daeda0929fdb5e |
Current assignee @sakluger is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik ( |
So, is this job already taken by @kbecciv ? The proposal sounds reasonable. It'd be redundant to make another. |
📣 @princemaple! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
ProposalPlease re-state the problem that we are trying to solve in this issue.Web - Still able to access participants page of archived room - Result in empty page What is the root cause of that problem?We are not checking if report is archived in participants page, we should not show the page when report is archived this problem also exists in other pages too. The similar issue was also reported #22997. I think we should fix all pages like this all at once. What changes do you think we should make in order to solve the problem?We should add condition
We should make sure we are covering all routes that might have this issue.Also I noticed similar issue here.(I am not sure if this one should be treated as separate since root cause and solution is different.) So we should also add
report: {
key: ({route}) => `${ONYXKEYS.COLLECTION.REPORT}${route.params.reportID}`,
}, App/src/pages/tasks/TaskDescriptionPage.js Lines 58 to 59 in a32fa95
report: {
key: ({route}) => `${ONYXKEYS.COLLECTION.REPORT}${getReportID(route)}`,
}, What alternative solutions did you explore? (Optional) |
@robertKozik mind taking a look at the proposals we're received so far? If you don't think they will fix the issue, we can wait for more proposals. If they are close but need to be tweaked, we can ask for updated proposals. Thanks! |
@sakluger sure on it! |
Hi All! Thank you all for your proposals @hungvu193 @alitoshmatov! I believe that both of your proposals are the same in a way of tackling with the issue - updating the condition of the As I believe we should stick to the main problem of this issue I think the proposal from @kbecciv should be accepted as it came up with te updating condition of the Selected proposal: proposal 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @Li357, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Thanks @robertKozik, that was proposal from me. @kbecciv posted it for me as I'm the reporter 😄 |
@robertKozik As you can see in my proposal we have the same issue in As for task related routes, I believe they will be handled here - #22451 |
Sorry, got distracted @hungvu193. Thanks for pointing it out, already changed my comment |
I also reported issue for ReportSettingPages and proposed the solution for it as well, in case we want to fix it here, I'm just ok with it. |
If it's basically the same root cause on multiple pages, it makes sense to fix all here rather than manage multiple jobs to fix pretty much the same thing. Let's see what @Li357 has to say, but I'm a fan of fixing everything at once. @hungvu193 you mentioned that you reported the issue for ReportSettingsPages too, is there another GH issue or Slack post for that? If so, we can consolidate. |
It's here: #23471. With SettingPages, it will be little different because it also related to the title of room. But the TaskPage is totally difference, we shouldn't handle it here :| |
Yeah, I agree if the same root cause is on other pages, we could fix it with one sweep |
I think we can handle ReportParticipantsPage, ReportSettingsPage, NotificationPreferencePage all one in go, and since @hungvu193 proposed a solution first to the first two components I'm inclined to hand this to them. And I also agree tasks are slightly different because archiving a chat room lends itself more to showing a not found page. @hungvu193 can we make sure to check all pages that show report(non-task)-related information and make sure they handled archival gracefully? |
Sure @Li357 |
📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app! |
🎯 ⚡️ Woah @robertKozik / @hungvu193, great job pushing this forwards! ⚡️ The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉
On to the next one 🚀 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.49-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-10. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Paid out @hungvu193 for bug report and contributor payment (with efficiency bonus 🚀 ). @robertKozik could you please finish filling out the bugzero checklist? Thanks! |
@sakluger sorry forgot about that 🙇🏼
I don't think there is an exact PR which introduced it. But I think the regression test for such a bugs should be created |
Thank you! Regression test steps look good, I've made the corrresponding issue for QA. Closing out 👍 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
If chat room is archived, PageNotFound should be showed.
Actual Result:
The participant page is empty.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen.Recording.2023-07-23.at.16.08.46.mov
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690103304727759
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: