Deploy Checklist: New Expensify 2023-05-15

[OSBotify]

Release Version: 1.3.14-14
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Clean up MoneyRequestModal #16976
• Fix keyboard flicker and input overlap in SignInPage #17445
• fix/15605: Run E2E performance tests on any branch #17972
• Disables the Button during onPress call in PressableWithFeedback #18122
• Add code to NewDot to handle both new and old Pusher event types #18192
• Migrate Forms into NewContactMethodPage  #18223
• Prevent duplicate requests on network failure #18237
• Add ReportActionItemThread and Thread Replies UI  #18274
• Use goBack so that the < works for threads and other chats #18350
• Fix frequently used emojis list doesn't get updated when adding emojis by typing emoji code with colon #18396
• [No QA] Use Ping endpoint for internet reachability instead of API root #18460
• Implement the RequestPreview component and update the IOUPreview #18486
• New Thread Report Empty State, Header, LHN, OpenReport, Buttons for DEV #18522
• Display iou or expense in LHN #18537
• Use IOU/Expense reportID for IOU actions #18604
• Fix - On increasing the screen size the user can see the previous image in the list #17760 #18615
• Fix - i accept the expensify terms of service, checkbox is not checked when connected online with plaid #18633
• Further changes for #17202 #18635
• Feat: Share QR Code #18636
• Fix: Don't add new content an already opened carousel #18651
• Edit Task Front End #18672
• Fix: (Redo) Copying the messages and marking a message in between as unread generates 'new' in the text #18684
• [No QA] Add caching to iOS build #18694
• Fix: Auto focus on mWeb when open report with enough chat history #18699
• Fix: Copy selection to clipboard is inconsistent between Chrome and Safari #18700
• fix/ copmpser hide on change screen size #18702
• Reupgrade react-native-image-manipulator package to allow Android GIF avatars #18703
• show individual split amount on Bill Split IOU Previews #18715
• Make sure when admin request from its workspace the participants are correctly listed #18717
• [Manual Requests] Create thread for Manual Request when opening IOUPreview #18760
• [No QA] Add some tests for IOU.payMoneyRequestElsewhere #18765
• Green DotIndicator Fix #18767
• Append LTR unicode on Android only #18768
• Adjust IOUPreview height based on description availability #18774
• UI MoneyRequestHeader Polish #18775
• [NO QA] Reset the min supported iOS version to 13 #18778
• Invert amount money request amount from negative to positive and vice-versa  #18783
• Add betas settings for threads #18787
• fix skeleton loading forever on options list when offline #18788
• Change LHN header to Expensify #18802
• expensify-commmon fix auto link after email domain not parsed #18804
• [No QA] Enforce there's no prettier diff in PR checks #18820
• [No QA] make prettier happy #18821
• Corrected - Chat mp4 files with long name extend to the far edges of the screen #18830
• [NoQA] Fix e2e pipeline #18835
• fix: android app crash fix due to wrong position of LayoutAnimation #18842
• Task auto focus fix #18889
• fix: call onModalHide when the confirm modal is closed #18897
• Ensure deleted and settled request messages show as text #18898
• [No QA] fix propType warning, make prettier happy #18929
• Corrected - IOU Description extends beyond the page if recipient name is long #18933
• Fix search preview #18941
• update report preview message to use workspace name, not admin name #18945
• [NoQA] Running prettier on main to fix overlooked issues  #18947
• Revert "[No QA] Use Ping endpoint for internet reachability instead of API root" #18948
• prevent grouping created action message #19019

Internal QA:

• Allow all filetypes to be uploaded #18521 - @youssef-lr

Deploy Blockers:

• [HOLD for payment 2023-05-23] [$1000] [HOLD for payment 2023-05-22] Unable to drag and drop an attachment after trying to upload a non-supported attachment. #18888
• Request Money - Every RM creates a second chat with own account. #18969
• IOU - Blank page when opening the detail page of IOU request #18973
• [HOLD for TestRail] [$2000] Web - Request - App crashes after user splits bills & requests money & then signs out for specific account  #18979
• [HOLD for payment 2023-05-25] [HOLD for payment 2023-05-23] senders avatar and name are missing on create new chat and send message #19010
• [HOLD for payment 2023-06-02] [$1000] LHN shows the current user's avatar #19034
• [HOLD for payment 2023-06-02] Web - Login - User gets 'Magic Code' instead of 'Abracadabra, you are signed in' message #19047

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.14-4 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.14-5 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.14-5 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.14-6 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.14-6 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.14-7 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.14-7 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.14-8 🚀

[mountiny]

Regression is almost done

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.14-8 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.14-9 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.14-9 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.14-10 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.14-10 has been deployed to staging 🎉

[mvtglobally]

Regressions is almost done, checklist is big, we are still working through the PRs.

current summary
#18898 failing #18973
#18783 failing #19035

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.14-11 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.14-12 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.14-11 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.14-13 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.14-14 🚀

[mvtglobally]

Still finishing up CPs @yuwenmemon

Need help here
#18274 (comment)
#18237 & #18945, can you help QA internally?
#18636 is failing #19032. Not repro in PROD as new feature, no blocker. pls double check
#18672 is failing #19044. Not repro in PROD as new feature, no blocker. pls double check
#18783 is failing #19035 Not repro in PROD as new feature, no blocker. pls double check
#18898 is failing #18973. Blocker has been removed, ok to checkoff?

Other issues
#18702 is failing
#19038. repro in PROD, checking off

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.14-12 has been deployed to staging 🎉

[yuwenmemon]

#18636 is failing #19032. Not repro in PROD as new feature, no blocker. pls double check
#18672 is failing #19044. Not repro in PROD as new feature, no blocker. pls double check
#18783 is failing #19035 Not repro in PROD as new feature, no blocker. pls double check
#18898 is failing #18973. Blocker has been removed, ok to checkoff?

Yep, checked them all off 👍

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.14-13 has been deployed to staging 🎉

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.14-14 has been deployed to staging 🎉

[mvtglobally]

#18702 is failing with ki #18448 (comment) & #19038 repro in prod. Checking off

[mvtglobally]

near the end summary @yuwenmemon

#18604 failing on WebIOS #19066 (yet to test mWeb/Android/Desktop)
#18274 failing #19077, new feature pls double check (yet to test mWeb)
#18522 is failing on Web/Desktop #19068 (yet to test mWeb/Android/IOS)
#18760 failing on web/desktop/mweb #19082 (yet to test Android/IOS)

[mvtglobally]

#18684 (comment) Can someone double check Desktop as well. We were not consistently able to repro, not sure if Blocker or no

[yuwenmemon]

#18274 failing #19077, new feature pls double check (yet to test mWeb)

That's by design - checking it off!

[yuwenmemon]

#18604 failing on WebIOS #19066 (yet to test mWeb/Android/Desktop)

That's still a feature in progress, not a blocker - checking it off!

[mvtglobally]

Final Summary @yuwenmemon

#18522 is failing on Web/Desktop #19068 (yet to test mWeb/Android/IOS) Can you help ?
#18684 (comment) Can someone double check Desktop as well. We were not consistently able to repro, not sure if Blocker or no
#18760 failing #19082
#18933 (comment) Can someone double check Desktop as well. We were not consistently able to repro, not sure if Blocker or no

[yuwenmemon]

#18522 is failing on Web/Desktop #19068 (yet to test mWeb/Android/IOS) Can you help ?

Just talked with @chiragsalian we're not going to block on that. Checking it off!

[yuwenmemon]

#18684 (comment) Can someone double check Desktop as well. We were not consistently able to repro, not sure if Blocker or no

Let's not block on this either.

[yuwenmemon]

#18760 failing #19082

Discussed here, not a blocker.

[yuwenmemon]

#18933 (comment) Can someone double check Desktop as well. We were not consistently able to repro, not sure if Blocker or no

Agreed that's minor, and not going to block the deploy on that! Checking it off! We're done!

[yuwenmemon]