[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-10] [HOLD on #4114/#17767] [$500] iOS - Chat - When moving to another line, the word and emoji are close to each other.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with any account
3. In the compose box enter message with have lengthier letters like (j) and emoji

Expected Result:

Text entered with letters and emojis on the next line must not be close to each other

Actual Result:

When moving to another line, the word and emoji are close to each other

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• iOS / native

Version Number: 1.2.57.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5904758_ios_2001_cherep.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ebb233eae82dffea
• Upwork Job ID: 1622658479891505152
• Last Price Increase: 2024-03-05

Issue Owner

Current Issue Owner: @twisterdotcom

[twisterdotcom]

Sorry for the delay, I was getting my Android phone working as well to test it there too.

My first few of these, so taking the template from StackOverflowTeams: https://stackoverflowteams.com/c/expensify/questions/14418

• The "bug" is actually a bug.
• The bug is not a duplicate report of an existing GH
• The bug is reproducible, following the reproduction steps.
• The GH template is filled out as fully as possible
• The GH was created by an Expensify employee or a QA tester.
• The bug is an /App issue

---

So, as we can see from my checklist, I don't see this still occurring.

iOS v12-58.4

RPReplay_Final1674667829.MP4

Eugh, and my Android device still isn't working. Okay, in the meantime - I think this has self-resolved somehow. Could you confirm @kbecciv?

[twisterdotcom]

Okay, I tested this again today and I think this is a non-issue/resolved. Closing it.

[kbecciv]

@twisterdotcom Issue is still reproduced with build 1.2.64.3
Please type the message with lengthier letters like (j) and emoji, so you will be able to reproduce it.

[MelvinBot]

Current assignee @twisterdotcom is eligible for the Bug assigner, not assigning anyone new.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[twisterdotcom]

Okay, you're right? Yes, if it's a lower case letter than typically falls below the bottom line, it interferes ever so slightly with the next line, especially emoji. So q, j, g, y, and p I think:

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01ebb233eae82dffea

[MelvinBot]

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[twisterdotcom]

Should we revert the revert? Do you need to submit a new PR again?

[fabOnReact]

Update 6th June 2024

@twisterdotcom Sorry, maybe my previous comment was not clear.

• My PR react-native-live-markdown/pull/350 does not introduce any regression on iOS (see tests performed here).
• My PR react-native-live-markdown/pull/350 includes iOS-only changes and it does not introduce regressions on Android (see my comment here).

I will start working again on this task on Monday. Hopefully, I can help to get this issue fixed so that we can upgrade react-native-live-markdown and close Issue 14445.

[fabOnReact]

@twisterdotcom

Should we revert the revert? Do you need to submit a new PR again?

I quote Skalakid comment.

After a quick investigation I found out that the live markdown parser is using a different commit of expensify-common than E/App. Live Markdown parser uses a newer version of ExpeniMark that contains changes that block blockquote creation without space after

I will create PR that bumps the version in the Expensify App
I pulled the latest main and E/App has a newer version of expensify-common than live markdown. I can't reproduce this issue now

57d8b2b

Maybe with the latest version of expensify-common and react-native-live-markdown the issues do not reproduce anymore. I will verify this on Monday (unluckily now I have other commitments). Thanks

[twisterdotcom]

No worries, we can wait until Monday.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @eVoloshchak owed $250 via NewDot
• ROLE: @fabOnReact paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@twisterdotcom)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1622658479891505152/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[fabOnReact]

Update 10 July 2024

• Tested PR [CP Staging] Bump react-native-live-markdown to 0.1.82 #43255 (comment). The issue is fixed.
• Meta team needs to merge PR Avoid setting a lineHeight lower of the fontSize lineHeight with Text and TextInput facebook/react-native#44614.
• Regarding the Deploy Blocker. Issues 43332 and 43312 reverted PR 377. Our PR 350 did not introduce regression and is part of Expensify main branch (react-native-live-markdown version 0.1.83.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @eVoloshchak owed $500 via NewDot
• ROLE: @fabOnReact paid $500 via Upwork here

BugZero Checklist (@twisterdotcom)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1622658479891505152/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[JmillsExpensify]

$500 approved for @eVoloshchak

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Bump react-native-live-markdown to 0.1.82 #43255

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @fabOnReact requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Bump react-native-live-markdown to 0.1.82 #43255

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @fabOnReact requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: