-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test build CI integration should post results in the PR even if one platform fails #13784
Comments
Slack thread: #13784, unlocking specifically for the folks at Software Mansion. |
Sure, I'll take care of that! |
@roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@roryabraham Huh... This is 4 days overdue. Who can take care of this? |
@roryabraham 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it! |
PR is in review. |
@roryabraham, @staszekscp Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Just left another review on the PR. |
This was done a couple weeks ago |
Problem
With the help of @staszekscp, we recently built a CI integration that will run test builds on all PRs, and can be manually dispatched by authorized actors.
When testing this out with #13767, I noticed that the build succeeded on all platforms except one. However, upon completion there was no comment posted in the PR, so it's not easy (or at least not obvious how) to test the platforms that did succeed.
Solution
Make the final step that posts the comment run even if one or more platforms fail. A similar example can be seen here, and the resulting comment should be tailored to clearly show for which platforms the build was successful and for which it was not. This is useful information to a PR author and also can help others proactively test the platforms for which the build was successful.
The text was updated successfully, but these errors were encountered: