Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test build CI integration should post results in the PR even if one platform fails #13784

Closed
roryabraham opened this issue Dec 21, 2022 · 9 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@roryabraham
Copy link
Contributor

Problem

With the help of @staszekscp, we recently built a CI integration that will run test builds on all PRs, and can be manually dispatched by authorized actors.

When testing this out with #13767, I noticed that the build succeeded on all platforms except one. However, upon completion there was no comment posted in the PR, so it's not easy (or at least not obvious how) to test the platforms that did succeed.

Solution

Make the final step that posts the comment run even if one or more platforms fail. A similar example can be seen here, and the resulting comment should be tailored to clearly show for which platforms the build was successful and for which it was not. This is useful information to a PR author and also can help others proactively test the platforms for which the build was successful.

@roryabraham roryabraham added Engineering Daily KSv2 Improvement Item broken or needs improvement. labels Dec 21, 2022
@roryabraham roryabraham self-assigned this Dec 21, 2022
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Dec 21, 2022
@roryabraham
Copy link
Contributor Author

roryabraham commented Dec 21, 2022

Slack thread: #13784, unlocking specifically for the folks at Software Mansion.

@Expensify Expensify unlocked this conversation Dec 21, 2022
@staszekscp
Copy link
Contributor

Sure, I'll take care of that!

@melvin-bot melvin-bot bot added the Overdue label Dec 26, 2022
@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels Dec 27, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jan 3, 2023

@roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Jan 5, 2023

@roryabraham Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Jan 9, 2023

@roryabraham 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@roryabraham
Copy link
Contributor Author

PR is in review.

@melvin-bot
Copy link

melvin-bot bot commented Jan 17, 2023

@roryabraham, @staszekscp Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@roryabraham
Copy link
Contributor Author

Just left another review on the PR.

@roryabraham
Copy link
Contributor Author

This was done a couple weeks ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants