From f1fe084a7d953fdd572e74cb919078eddf785723 Mon Sep 17 00:00:00 2001 From: Timon Pike Date: Fri, 6 Oct 2023 14:55:26 -0700 Subject: [PATCH] try closing the process inside the process definition, don't have the parent wait. --- go/internal/feast/transformation/transformation.go | 5 +---- go/internal/feast/transformation/transformation_test.go | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/go/internal/feast/transformation/transformation.go b/go/internal/feast/transformation/transformation.go index 74294442be..01a18dd4d8 100644 --- a/go/internal/feast/transformation/transformation.go +++ b/go/internal/feast/transformation/transformation.go @@ -169,15 +169,12 @@ func CallTransformations( transformResp <- TransformChannel{outRecord, nil} } } + p.Close() }) resp := <-transformResp if resp.err != nil { return nil, resp.err } - err := proc.Close() - if err != nil { - return nil, err - } result := make([]*onlineserving.FeatureVector, 0) for idx, field := range resp.outRecord.Schema().Fields() { diff --git a/go/internal/feast/transformation/transformation_test.go b/go/internal/feast/transformation/transformation_test.go index 141ec52435..b70557cf4f 100644 --- a/go/internal/feast/transformation/transformation_test.go +++ b/go/internal/feast/transformation/transformation_test.go @@ -40,7 +40,7 @@ func createOnDemandFeatureView(name string, featureSources map[string][]*core.Fe return model.NewOnDemandFeatureViewFromProto(proto) } -func TestCallTransformations(t *testing.T) { +func TestCallTransformationsFailsWithError(t *testing.T) { featASpec := createFeature("featA", prototypes.ValueType_INT32) featBSpec := createFeature("featB", prototypes.ValueType_INT32) onDemandFeature1 := createFeature("featC", prototypes.ValueType_FLOAT)