From 0c9d134d2c23b14f26e484c41616cd95cb8473d4 Mon Sep 17 00:00:00 2001 From: Georgi Ivanov Date: Tue, 19 Mar 2024 15:27:37 +0000 Subject: [PATCH 1/2] we cannot have providers in modules and use count on module invocation to conditionally enable the module on or off as per https://developer.hashicorp.com/terraform/language/modules/develop/providers#legacy-shared-modules-with-provider-configurationsWq --- common.tf | 5 ----- 1 file changed, 5 deletions(-) diff --git a/common.tf b/common.tf index dc38331..0b11d38 100644 --- a/common.tf +++ b/common.tf @@ -64,8 +64,3 @@ data "external" "datadog_key" { count = length(var.datadog_key_secret_name) > 0 ? 1 : 0 program = ["echo", "${data.aws_secretsmanager_secret_version.datadog_key[0].secret_string}"] } - -provider "datadog" { - api_key = chomp(data.external.datadog_key[0].result["api_key"]) - app_key = chomp(data.external.datadog_key[0].result["app_key"]) -} From ec8181d7ecedb93257f26c682efb299299cc1dac Mon Sep 17 00:00:00 2001 From: Georgi Ivanov Date: Tue, 26 Mar 2024 12:00:33 +0000 Subject: [PATCH 2/2] update CHANGELOG --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1b4d5a5..02dbc67 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). +## [4.3.2] - 2024-03-26 +### Updated +- Removed the datadog explicit provider configuration as suggested here: https://developer.hashicorp.com/terraform/language/modules/develop/providers#legacy-shared-modules-with-provider-configurations + ## [4.3.1] - 2024-02-22 ### Updated - Updated eks to use instance name instead of hard coding.