From 828da605b265649b1e30c1ba7a007fdedcb62e52 Mon Sep 17 00:00:00 2001 From: janli Date: Tue, 2 Apr 2024 10:46:51 -0700 Subject: [PATCH 1/4] fix: changed datadog_key_secret_name default value --- CHANGELOG.md | 5 +++++ VARIABLES.md | 2 +- variables.tf | 6 +++--- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ada126d..0f1f68c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,11 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). +## [7.1.1] - 2024-04-02 +### Fixed +- Renamed variable from `common_producer_iamroles` to `apiary_common_producer_iamroles` to make the name consistently. +- Change default value for `datadog_key_secret_name` from `null` to `""`. + ## [7.1.0] - 2024-03-21 ### Added - Added `common_producer_iamroles` to allow roles read-write access to all Apiary managed schemas. diff --git a/VARIABLES.md b/VARIABLES.md index 3bd023c..dc25a7c 100644 --- a/VARIABLES.md +++ b/VARIABLES.md @@ -24,7 +24,7 @@ | atlas\_cluster\_name | Name of the Atlas cluster where metastore plugin will send DDL events. Defaults to `var.instance_name` if not set. | `string` | `""` | no | | atlas\_kafka\_bootstrap\_servers | Kafka instance url. | `string` | `""` | no | | aws\_region | AWS region. | `string` | n/a | yes | -| common\_producer\_iamroles | AWS IAM roles allowed general (not tied to schema) write access to managed Apiary S3 buckets. | `list(string)` | `[]` | no | +| apiary\_common\_producer\_iamroles | AWS IAM roles allowed general (not tied to schema) write access to managed Apiary S3 buckets. | `list(string)` | `[]` | no | | dashboard\_namespace | k8s namespace to deploy grafana dashboard. | `string` | `"monitoring"` | no | | db\_apply\_immediately | Specifies whether any cluster modifications are applied immediately, or during the next maintenance window. | `bool` | `false` | no | | db\_backup\_retention | The number of days to retain backups for the RDS Metastore DB. | `string` | n/a | yes | diff --git a/variables.tf b/variables.tf index c426ab7..1f48a34 100644 --- a/variables.tf +++ b/variables.tf @@ -719,7 +719,7 @@ variable "hms_ro_request_partition_limit" { variable "datadog_key_secret_name" { description = "Name of the secret containing the DataDog API key. This needs to be created manually in AWS secrets manager. This is only applicable to ECS deployments." type = string - default = null + default = "" } variable "datadog_agent_version" { @@ -734,8 +734,8 @@ variable "datadog_agent_enabled" { default = false } -variable "common_producer_iamroles" { +variable "apiary_common_producer_iamroles" { description = "AWS IAM roles allowed read-write access to managed Apiary S3 buckets." type = list(string) default = [] -} \ No newline at end of file +} From cc3d7686f8d825a5d4b5e806df2acadc0435155f Mon Sep 17 00:00:00 2001 From: janli Date: Tue, 2 Apr 2024 10:51:29 -0700 Subject: [PATCH 2/4] fix: fixed typo --- s3.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s3.tf b/s3.tf index c4bf078..3c5211f 100644 --- a/s3.tf +++ b/s3.tf @@ -25,7 +25,7 @@ locals { client_roles = replace(lookup(schema, "client_roles", ""), ",", "\",\"") governance_iamroles = join("\",\"", var.apiary_governance_iamroles) consumer_prefix_roles = lookup(var.apiary_consumer_prefix_iamroles, schema["schema_name"], {}) - common_producer_iamroles = join("\",\"", var.common_producer_iamroles) + common_producer_iamroles = join("\",\"", var.apiary_common_producer_iamroles) }) } } From 999dfd33bac2eda33b4a548f39afdf9197f7f8e6 Mon Sep 17 00:00:00 2001 From: Jay Green-Stevens Date: Wed, 3 Apr 2024 09:46:00 +0100 Subject: [PATCH 3/4] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0f1f68c..dcbf8c1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,7 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). -## [7.1.1] - 2024-04-02 +## [7.1.1] - 2024-04-03 ### Fixed - Renamed variable from `common_producer_iamroles` to `apiary_common_producer_iamroles` to make the name consistently. - Change default value for `datadog_key_secret_name` from `null` to `""`. From aa103a5e5c359f5c1e79b265b2641f435dc1fdb1 Mon Sep 17 00:00:00 2001 From: Jay Green-Stevens Date: Wed, 3 Apr 2024 09:46:30 +0100 Subject: [PATCH 4/4] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dcbf8c1..ab20c34 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a ## [7.1.1] - 2024-04-03 ### Fixed -- Renamed variable from `common_producer_iamroles` to `apiary_common_producer_iamroles` to make the name consistently. +- Renamed variable from `common_producer_iamroles` to `apiary_common_producer_iamroles` to make the name consistent. - Change default value for `datadog_key_secret_name` from `null` to `""`. ## [7.1.0] - 2024-03-21